-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: revert deletion of influx
CLI code
#21919
Conversation
This reverts commit 302c355.
Ugh, that's probably caused by this line, which I added to work around this issue while the fix was still unreleased. I'll open an issue in |
Sounds good...definitely a big improvement over the previous version which didn't work at all on powershell! |
Speaking of previous versions...are you going to make any |
Yes, I'll make a note about fixing the interactive I/O on powershell. I think that'll be the only bugfix from this... other bugs that got fixed in the new |
(Mostly) reverts #21877
Best reviewed commit-by-commit:
git revert
. There were some conflicts ingo.mod
and code undercmd/influxd
where things got cleaned up after the CLI was deleted; I edited the revert-patch to not change those spotsgo-input
-based functions for interactive I/O, replacing those usages with calls to utilities from the new CLI. This should fix problems users were hitting in powershellpkg/csv2lp
, which was copied verbatim toinflux-cli
pkg/jsonnet
, which was copied verbatim toinflux-cli