chore: update deps to ones that use maintained form3tech-oss/jwt-go #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockstar
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
While I ran make test and it passed, I did not do any further verification for correctness.
I don't think anyone on the team has any expertise on the places where these dependencies are used. For instance, the Azure/go-autorest is part of the mssql_azure sql provider, which has no tests (at least for that specific functionality).
I am of the opinion that we should make this change if only for the vulnerabilities attached, and if things break, we take that time to write some tests to verify it. Otherwise we'll continue to add to our maintenance burden without any sort of assurances that we can scale. @nathanielc, does that sound right to you?
jdstrand
changed the title
jdstrand
force-pushed
the
update-deps-for-jwt-go
branch
from
e6d0095 to
677a606
Compare
The dgrijalva/jwt-go project is no longer maintained and has a security vulnerability. Update our dependencies that pull in jwt-go to new versions that use the security-patched form3tech-oss/jwt-go. The following was performed: 1. update go.mod to use go-autorest/autorest/adal v0.9.5 (the first release to use form3tech-oss/jwt-go) 2. update go.mod to use go-autorest/autorest/azure/auth v0.5.3 (the first release to use adal v0.9.5) 3. update go.mod to use snowflakedb/gosnowflake v1.3.13 (the latest 1.3.x release, which uses form3tech-oss/jwt-go) 4. go mod tidy 5. make test References: - dgrijalva/jwt-go#462
jdstrand
force-pushed
the
update-deps-for-jwt-go
branch
from
677a606 to
0ffe5c9
Compare
JustSomeCarbon
pushed a commit
that referenced
this pull request
Aug 9, 2021
…3901) The dgrijalva/jwt-go project is no longer maintained and has a security vulnerability. Update our dependencies that pull in jwt-go to new versions that use the security-patched form3tech-oss/jwt-go. The following was performed: 1. update go.mod to use go-autorest/autorest/adal v0.9.5 (the first release to use form3tech-oss/jwt-go) 2. update go.mod to use go-autorest/autorest/azure/auth v0.5.3 (the first release to use adal v0.9.5) 3. update go.mod to use snowflakedb/gosnowflake v1.3.13 (the latest 1.3.x release, which uses form3tech-oss/jwt-go) 4. go mod tidy 5. make test References: - dgrijalva/jwt-go#462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dgrijalva/jwt-go project is no longer maintained and has a security
vulnerability. Update our dependencies that pull in jwt-go to new
versions that used the security-patched form3tech-oss/jwt-go.
The following was performed:
release to use form3tech-oss/jwt-go)
first release to use adal v0.9.5)
1.3.x release, which uses form3tech-oss/jwt-go)
References:
IMPORTANT: while gosnowflake remains on v1.3.x, adal moves from 0.8.x to 0.9.x and azure/auth moves from 0.4.x to 0.5.x. While I ran
make testand it passed, I did not do any further verification for correctness. Also note, I chose the highest v.1.3.x version for gosnowflake since that seemed safest, but the lowest versions of adal and azure/auth that has the dep fix. I did not verify these for open issues, etc since I felt someone more knowledgeable in flux's use of these dependencies would have more insight on the risk. IMHO, it would be fine to close the PR and instead open another that chooses whatever version of these deps makes sense for flux.Done checklist