Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql): add Snowflake support #2707

Merged
merged 3 commits into from
Apr 30, 2020
Merged

feat(sql): add Snowflake support #2707

merged 3 commits into from
Apr 30, 2020

Conversation

alespour
Copy link
Contributor

This PR adds Snowflake support to sql package.

Done checklist

  • docs/SPEC.md updated
  • Test cases written

@alespour alespour marked this pull request as ready for review March 31, 2020 09:20
@sanderson sanderson mentioned this pull request Mar 31, 2020
Closed
@nathanielc nathanielc requested a review from jsternberg April 23, 2020 23:01
rockstar
rockstar reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@rockstar rockstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work. I have a couple of suggestions for things that could change for this patch. Happy to take a look again when they've been addressed.

stdlib/sql/to_privates_test.go Outdated Show resolved Hide resolved
stdlib/sql/snowflake.go Outdated Show resolved Hide resolved
stdlib/sql/snowflake.go Outdated Show resolved Hide resolved
stdlib/sql/snowflake.go Show resolved Hide resolved
@rockstar rockstar self-assigned this Apr 28, 2020
@rockstar rockstar merged commit aff8331 into influxdata:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockstar rockstar rockstar approved these changes

@nathanielc nathanielc Awaiting requested review from nathanielc

@jsternberg jsternberg Awaiting requested review from jsternberg

Assignees

@rockstar rockstar

Labels
chore team/query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alespour @rockstar @timhallinflux