Skip to content

Commit

Permalink
chore: Remove the version range from lsp-types (#5067)
Browse files Browse the repository at this point in the history
This does not work as I would hope (see rust-lang/cargo#9029) so we need
to restrict this to just the same version that lspower uses (for the sake of the LSP). This is bad in its own way though as lspower does not adhere to semver which can cause its own breakages.

Personally I'd like use to remove the `From` implementations we provided here and let the LSP have its own, explicit conversions so we could avoid this churn 🤷.
  • Loading branch information
Markus Westerlind authored Aug 10, 2022
1 parent 605c60c commit 76a0e37
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions libflux/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion libflux/flux-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ fnv = "1.0.7"
indexmap = "1"
libflate = "1.2.0"
log = "0.4.16"
lsp-types = { version = ">=0.91,<=0.92", optional = true }
lsp-types = { version = "0.91", optional = true }
maplit = "1.0.2"
once_cell = { version = "1.10.0", optional = true }
pad = { version = "0.1.6", optional = true }
Expand Down
4 changes: 2 additions & 2 deletions libflux/go/libflux/buildinfo.gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ package libflux
// are not tracked by Go's build system.'
//lint:ignore U1000 generated code
var sourceHashes = map[string]string{
"libflux/Cargo.lock": "67373da0755f957cf04d90fb58d9873cfafb5bef382d1535e49a5bf6c23febf0",
"libflux/Cargo.lock": "d22aefaaab124dba2e5bcb521d44610e400d745a36a97b29665ee3db51b4a6ca",
"libflux/Cargo.toml": "91ac4e8b467440c6e8a9438011de0e7b78c2732403bb067d4dd31539ac8a90c1",
"libflux/flux-core/Cargo.toml": "b94689ddd00f579300ef6828696c80e7a29898307e2d27ab4d039ef992c27c38",
"libflux/flux-core/Cargo.toml": "979e410d4eef8318364ac9203bd0eedaa49ddd71043ed3402edd70ed5436286e",
"libflux/flux-core/src/ast/check/mod.rs": "47e06631f249715a44c9c8fa897faf142ad0fa26f67f8cfd5cd201e82cb1afc8",
"libflux/flux-core/src/ast/mod.rs": "4db1054af8625721300429b8ce0eacda6f8e6d8f20251874a87bb5bc884885c8",
"libflux/flux-core/src/ast/walk/mod.rs": "a74d90937d4f059800f39ff866976c68ff06c3566293aec65f1539ddc2f1de25",
Expand Down

0 comments on commit 76a0e37

Please sign in to comment.