Skip to content

Conversation

@erratic-pattern
Copy link

@erratic-pattern erratic-pattern commented Dec 15, 2025

Related tracking issue: https://github.com/influxdata/influxdb_iox/issues/15268

Purpose

This revision re-enables the physical schema check as an error (rather than a warning) to allow creating a failing E2E test that demonstrates the DataFusion bug described in:

https://github.com/influxdata/influxdb_iox/pull/15790 uses this revision to show that the test fails when the schema mismatch assertion is enabled.

Note: This is a temporary branch for testing purposes only, not intended for production use.

Included Patches

All patches from #78 except the warning-only patch listed below.

Removed Patches

  1. 4e7ad0d - chore: re-enable physical schema check and log a warning instead of error

crepererum and others added 13 commits September 5, 2025 12:54
)

Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20.
- [Release notes](https://github.com/tokio-rs/tracing/releases)
- [Commits](tokio-rs/tracing@tracing-subscriber-0.3.19...tracing-subscriber-0.3.20)

---
updated-dependencies:
- dependency-name: tracing-subscriber
  dependency-version: 0.3.20
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rceDistribution) which later causes an error during EnforceSort (without our patch). The next DataFusion version 46 upgrade does the proper fix, which is to not insert the coalesce in the first place.

test: recreating the iox plan:
* demonstrate the insertion of coalesce after the use of column estimates, and the removal of the test scenario's forcing of rr repartitioning

test: reproducer of SanityCheck failure after EnforceSorting removes the coalesce added in the EnforceDistribution

fix: special case to not remove the needed coalesce
…pache#17003)

* Support centroids config for `approx_percentile_cont_with_weight`

* Match two functions' signature

* Update docs

* Address comments and unify centroids config
…ntile_cont_with_weight` (apache#16999)

* Add sqllogictests

* Allow both new and old sytanx for approx_percentile_cont and approx_percentile_cont_with_weight

* Update docs

* Add documentation and more tests
* feat: support distinct for window

* fix

* fix

* fisx

* fix unparse

* fix test

* fix test

* easy way

* add test

* add comments
…he#17404)

* test: regression test for apache#17372

* test: add more direct regression for apache#17372

* fix: return ALL constants in `EquivalenceProperties::constants`
…he#17431)

* feat: Support binary data types for `SortMergeJoin` `on` clause

* Add sql level tests for merge join on binary keys

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* test: reproducer of bug
* fix: make schema names unique for approx_percentile_cont
* test: regression test is now resolved
@erratic-pattern erratic-pattern marked this pull request as draft December 15, 2025 17:35
@erratic-pattern erratic-pattern changed the title Patched DF 49.0.2 (revision d) - Schema check as error for testing Patched DF 49.0.2 (revision d) - for testing purposes only Dec 15, 2025
@alamb
Copy link
Collaborator

alamb commented Jan 6, 2026

this was for testing, so closing it down

@alamb alamb closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants