Skip to content

Commit

Permalink
Refactor: more clearly delineate between TableParquetOptions and `P…
Browse files Browse the repository at this point in the history
…arquetWriterOptions` (apache#11444)

* refactor: make more explicit the relationship btwn TableParquetOptions vs ParquetOptions vs WriterProperties

* test: demonstrate the relationship btwn session configs and writer props

* refactor: move parquet-format specific functionality to the parquet submodule, leaving only the config options in the config module.

* test: update test fixtures to use the ParquetOptions::default

* test: update test helper session_config_from_writer_props, to not add column configuration when none exists

* test(11367): write test to demonstrate issue 11367

* fix: existing sqllogictests require specific ParquetOptions settings to be left as None

* test(11367): demonstrate how the require bloom filter defaults, (required to avoid test regression), result in different default behavior than parquet crate

* chore: make more reviewable, by pulling tests for issue 11367 into followup PR

* refactor: move all parquet-associated features into parquet-writer mod

* chore: better function naming convention
  • Loading branch information
wiedld committed Jul 31, 2024
1 parent 5ecf6aa commit 269799b
Showing 1 changed file with 320 additions and 89 deletions.
Loading

0 comments on commit 269799b

Please sign in to comment.