Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #86

Merged
merged 6 commits into from
Apr 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
Changelog
=========

## Version 5.3.0

_2021-04-10_

* Update Gradle from 6.8.3 to 7.0.
* Migrate from dependencies.gradle to version catalogs.
* Update dependencies to more stable releases.
* Remove Bintray deployment configuration.

## Version 5.2.9

_2021-03-25_
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ Then add the following dependencies in your app `build.gradle` or `build.gradle.

**Groovy**
```groovy
debugImplementation "com.infinum.dbinspector:dbinspector:5.2.9"
releaseImplementation "com.infinum.dbinspector:dbinspector-no-op:5.2.9"
debugImplementation "com.infinum.dbinspector:dbinspector:5.3.0"
releaseImplementation "com.infinum.dbinspector:dbinspector-no-op:5.3.0"
```
**KotlinDSL**
```kotlin
debugImplementation("com.infinum.dbinspector:dbinspector:5.2.9")
releaseImplementation("com.infinum.dbinspector:dbinspector-no-op:5.2.9")
debugImplementation("com.infinum.dbinspector:dbinspector:5.3.0")
releaseImplementation("com.infinum.dbinspector:dbinspector-no-op:5.3.0")
```

### Usage
Expand Down
26 changes: 11 additions & 15 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@ buildscript {

apply from: "config.gradle"
apply from: "maven.gradle"
apply from: "dependencies.gradle"

repositories {
google()
mavenCentral()
gradlePluginPortal()
}
dependencies {
classpath packages.gradle
classpath packages.kotlin.plugin
classpath packages.cpd.plugin
classpath packages.detekt.plugin
classpath packages.ktlint.plugin
classpath packages.dokka.plugin
classpath packages.google.protobuf.plugin
classpath libs.gradle
classpath libs.kotlin.plugin
classpath libs.cpd
classpath libs.detekt.plugin
classpath libs.ktlint
classpath libs.dokka
classpath libs.protobuf.plugin
}
}

Expand All @@ -26,12 +25,7 @@ allprojects {
mavenCentral()
jcenter() {
content {
includeModule("com.soywiz.korlibs.korte", "korte-jvm")
includeModule("org.jetbrains.trove4j", "trove4j")
includeModule("org.jetbrains.kotlinx", "kotlinx-html-jvm")
includeGroup("org.jetbrains.dokka")
includeGroup("org.jetbrains")
includeGroup("org.koin")
}
}
}
Expand All @@ -42,8 +36,10 @@ allprojects {
configurations.all {
resolutionStrategy {
dependencySubstitution {
substitute module(packages.dbinspector.dbinspector) with project(':dbinspector')
substitute module(packages.dbinspector.dbinspector_no_op) with project(':dbinspector-no-op')
def library = libs.library.get()
def librarynoop = libs.librarynoop.get()
substitute module(library.getModule().toString() + ":" + library.getVersionConstraint().toString()) with project(':dbinspector')
substitute module(librarynoop.getModule().toString() + ":" + librarynoop.getVersionConstraint().toString()) with project(':dbinspector-no-op')
}
}
}
Expand Down

This file was deleted.

4 changes: 2 additions & 2 deletions config.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ext {
]
releaseConfig = [
"group" : "com.infinum.dbinspector",
"version" : "5.2.9",
"versionCode": 5 * 100 * 100 + 2 * 100 + 9
"version" : "5.3.0",
"versionCode": 5 * 100 * 100 + 3 * 100 + 0
]
}
2 changes: 1 addition & 1 deletion dbinspector-no-op/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ android {
}

dependencies {
implementation packages.kotlin.core
implementation libs.kotlin.core
}

apply from: "publish.gradle"
8 changes: 0 additions & 8 deletions dbinspector-no-op/publish.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@ afterEvaluate {
password github.password()
}
}
maven {
name bintray.name()
url bintray.url() + "/dbinspector-no-op/;publish=1;override=1"
credentials {
username bintray.username()
password bintray.password()
}
}
}
publications {
release(MavenPublication) {
Expand Down
49 changes: 27 additions & 22 deletions dbinspector/build.gradle
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
plugins {
id "com.android.library"
id "kotlin-android"
id "com.google.protobuf"
}

apply from: "protobuf.gradle"

android {
compileSdkVersion buildConfig.compileSdk
buildToolsVersion buildConfig.buildTools
Expand Down Expand Up @@ -50,6 +49,7 @@ android {
}

sourceSets.each {
it.proto.srcDirs += "src/$it.name/proto"
it.java.srcDirs += "src/$it.name/kotlin"
}

Expand All @@ -59,26 +59,31 @@ android {
}

dependencies {
implementation packages.kotlin.core
implementation packages.androidx.core
implementation packages.androidx.appcompat
implementation packages.androidx.activity
implementation packages.androidx.fragment
implementation packages.androidx.recyclerview
implementation packages.androidx.viewpager
implementation packages.androidx.paging
implementation packages.androidx.startup
implementation packages.androidx.swiperefreshlayout
implementation packages.androidx.datastore
implementation packages.androidx.dynamicanimation
implementation packages.google.protobuf.javalite
implementation packages.google.design
implementation packages.kotlinx.coroutines
implementation packages.koin.android
implementation packages.koin.scope
implementation packages.koin.viewmodel
implementation packages.timber.core
implementation packages.fuzzy.core
implementation libs.kotlin.core
implementation libs.coroutines
implementation libs.bundles.androidx
implementation libs.protobuf.javalite
implementation libs.material
implementation libs.koin
implementation libs.timber
implementation libs.fuzzy
}

protobuf {
protoc {
def protobufArtifact = libs.protobuf.artifact.get()
artifact = protobufArtifact.getModule().toString() + ":" + protobufArtifact.getVersionConstraint().toString()
}

generateProtoTasks {
all().each { task ->
task.builtins {
java {
option "lite"
}
}
}
}
}

apply from: "publish.gradle"
2 changes: 1 addition & 1 deletion dbinspector/proguard-rules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
-keep class * extends com.google.protobuf.GeneratedMessageLite { *; }
-keep public class com.infinum.dbinspector.data.models.local.proto.output.* {
public protected *;
}
}
17 changes: 0 additions & 17 deletions dbinspector/protobuf.gradle

This file was deleted.

8 changes: 0 additions & 8 deletions dbinspector/publish.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@ afterEvaluate {
password github.password()
}
}
maven {
name bintray.name()
url bintray.url() + "/dbinspector/;publish=1;override=1"
credentials {
username bintray.username()
password bintray.password()
}
}
}
publications {
release(MavenPublication) {
Expand Down
87 changes: 0 additions & 87 deletions dependencies.gradle

This file was deleted.

2 changes: 0 additions & 2 deletions deploy.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
task deployDbInspector(dependsOn: [
':dbinspector:clean',
':dbinspector:publishReleasePublicationToBintrayRepository',
':dbinspector:publishReleasePublicationToGithubRepository',
':dbinspector:publishReleasePublicationToSonatypeRepository'
]) {
Expand All @@ -10,7 +9,6 @@ task deployDbInspector(dependsOn: [

task deployDbInspectorNoOp(dependsOn: [
':dbinspector-no-op:clean',
':dbinspector-no-op:publishReleasePublicationToBintrayRepository',
':dbinspector-no-op:publishReleasePublicationToGithubRepository',
':dbinspector-no-op:publishReleasePublicationToSonatypeRepository'
]) {
Expand Down
4 changes: 2 additions & 2 deletions detekt.gradle
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
apply plugin: "io.gitlab.arturbosch.detekt"

detekt {
toolVersion = versions.detekt
toolVersion = libs.versions.detekt.get()
}

dependencies {
detektPlugins packages.detekt.formatting
detektPlugins libs.detekt.formatting
}
Loading