fix(generate): add support for Expo Router app directory prompts #2905
Conversation
| @@ -52,6 +52,53 @@ async function generate(toolbox: GluegunToolbox) { | |||
| pascalName = pascalName.slice(0, -1 * pascalGenerator.length) | |||
| command(`npx ignite-cli generate ${generator} ${pascalName}`) | |||
| } | |||
| // Check if src/app exists, denoting an Expo Router app | |||
| if (generator === "screen") { | |||
| const isExpoRouterApp = filesystem.exists("src/app") === "dir" | |||
There was a problem hiding this comment.
So this is the correct directory structure to determine expo-router in an Ignite application, however omitting the src/ nesting is totally valid and it is possible a dir structure looks like this:
- app (the routes)
- components
- hooks
- etc...
This is in fact the default expo application structure and Ignite generators should continue to be compatible for any project, not just our opinionated structure.
So perhaps we should look into a different mechanism for determining this? Maybe we check app or src/app to cover both. Or look for package.json to have expo-router?
| if (frontMatterData?.destinationDir === undefined) { | ||
| warning(`⚠️ No front matter found in ${generator} template.`) | ||
| return undefined | ||
| } |
There was a problem hiding this comment.
Do we always want to warn here? I maybe only want to see this if I haven't provided --dir because if that's my workflow and I never set it in the template, it's going to show each time.
Description
This PR addresses a user who creates screens within an ignited app using
expo-router. It checks for the existence ofsrc/app(the expo router configuration) and then determines where to put the screen in 4 ways:destinationDirset from the screen generator templatesrc/app/Screenshots
src/appChecklist
README.mdand other relevant documentation has been updated with my changes