Improve i18n Test Output and Add Detailed Logging #2876
+140
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve i18n Test Output and Add Detailed Logging
rsoaresdev
changed the title
Fix grep command to work with absolute paths in CircleCI
mazenchami
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
@rsoaresdev thank you for putting this together. this is a great addition!
flexbox
reviewed
Jan 18, 2025
| let output = `--- i18n Test Results ---\n` | ||
| output += `Total keys defined: ${allKeysDefined.length}\n` | ||
| output += `Total keys used: ${allKeysUsed.length}\n` | ||
| output += `Missing keys: ${missingKeys.length > 0 ? missingKeys.join(", ") : "None"}\n` |
There was a problem hiding this comment.
Thanks, glad you liked it. That output is actually very useful.
|
I don't know why circle ci is not happy but locally I have this error when I run
|
The test uses process.cwd() to define the srcDir (process.cwd()/app), but Yarn’s sandbox creates temporary paths like /private/var/folders/..., which don’t always contain the expected project structure. When the grep command tries to scan these directories, it fails because the srcDir doesn’t exist. Can you try this way: |
- Add robust directory detection for various environments (Yarn, Bun, npm) - Handle temporary directories - Add fallback paths and better error messages - Verify directory existence before running grep command
|
With my last commit the issue finding the right path is fixed. Now circle ci is not happy because it encounters many keys that are missing: |
|
Looks like translation keys for demo code (that's why it only returned 12 keys defined). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve i18n Test Output and Add Detailed Logging
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
Description:
Changes:
This update improves the overall test process for missing or unused translation keys, making it easier to catch issues and understand the results.
Screenshots (if applicable)