This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Simplifies navigation, adds comments #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamonholmgren
changed the title
jamonholmgren
changed the title
jamonholmgren
commented
May 21, 2020
| @@ -14,6 +14,8 @@ const execaShell = (command: string, opts = {}) => execa(command, { shell: true, | |||
| describe("a generated app", () => { | |||
| // creates a new temp directory | |||
| const appTemp: string = tempy.directory() | |||
| console.log("Test app directory:", appTemp) | |||
markrickert
reviewed
May 21, 2020
markrickert
reviewed
May 21, 2020
markrickert
reviewed
May 21, 2020
markrickert
reviewed
May 21, 2020
harrisrobin
approved these changes
May 21, 2020
infinitered-circleci
pushed a commit
that referenced
this pull request
May 22, 2020
# [5.1.0](v5.0.3...v5.1.0) (2020-05-22) ### Bug Fixes * **types:** getRoot types fixed ([#340](#340) by [@nirre7](https://github.com/nirre7)) ([2e94b62](2e94b62)) ### Features * **boilerplate:** Upgrades to React Native 0.61.5, adds barrel file for models ([#341](#341) by [@nirre7](https://github.com/nirre7)) ([0c79752](0c79752)) * **deps:** Bump TS lib/target to esnext ([#343](#343) by [@robinheinze](https://github.com/robinheinze)) ([d3f9cc4](d3f9cc4)) * **navigation:** Simplifies navigation, adds helpful comments ([#338](#338) by [@jamonholmgren](https://github.com/jamonholmgren)) ([4abb814](4abb814))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm simplifying the navigation folder by combining some functions into a single utilities file, adding a
useNavigationPersistencehook to pull some code out ofapp.tsx, and adding a bunch of comments.(Tests are currently failing -- I'll fix that.)