-
Notifications
You must be signed in to change notification settings - Fork 150
Updates Reactotron to the latest version & techniques. #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Small nits
@@ -1,35 +1,34 @@ | |||
import { StartupTypes } from '../Redux/StartupRedux' | |||
// import { StartupTypes } from '../Redux/StartupRedux' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do or do not ... there is no try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving this here as an example.
// networking: {}, | ||
// editor: {} | ||
// } | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what's happening here. Are these on by default, and you're just showing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm showing an example.
// you can flag some of your actions as important by returning true here | ||
isActionImportant: action => action.type === StartupTypes.STARTUP, | ||
// isActionImportant: action => action.type === StartupTypes.STARTUP, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaning to do that for like 6 months. haha.
if (__DEV__ && console.tron) { | ||
api.addMonitor(console.tron.apisauce) | ||
} | ||
|
||
// ------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woah, awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have no headers now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you open an issue if you’re having a problem? Headers are coming through fine. I haven’t tried on 0.54 though. I hear there are changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skellock tried on a new ignite app (RN 0.50.4), everything is ok
Also: @skellock - if you plan to keep the stubs in place, please add overlay as a stub: |
@GantMan I added a DEV switch for that. |
I can also switch it to use the config settings as well.... or i can delete it. Either way, this is all temporary until I write/find that babel plugin. |
Alright, have a look again. I just swept thru & cleaned up everything. Making sure we're behind a consistent switch. |
This also fixes the issue of trying to use the Reactotron Overlay in production.
A few new features since 1.7:
reactotron-apisauce
is no longer needed. we place our hooks at theXMLHTTPRequest
level, so all networking requests are supported. 🎉AsyncStorage
is now trackedFixes #49