Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Updates Reactotron to the latest version & techniques. #59

Merged
merged 3 commits into from
May 25, 2017

Conversation

skellock
Copy link
Contributor

@skellock skellock commented May 24, 2017

This also fixes the issue of trying to use the Reactotron Overlay in production.

A few new features since 1.7:

  • reactotron-apisauce is no longer needed. we place our hooks at the XMLHTTPRequest level, so all networking requests are supported. 🎉
  • AsyncStorage is now tracked
  • nicer serialization (we now can track falsy values and better circular dependency detection)

Fixes #49

Copy link
Member

@GantMan GantMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Small nits

@@ -1,35 +1,34 @@
import { StartupTypes } from '../Redux/StartupRedux'
// import { StartupTypes } from '../Redux/StartupRedux'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do or do not ... there is no try

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving this here as an example.

// networking: {},
// editor: {}
// }
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what's happening here. Are these on by default, and you're just showing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm showing an example.

// you can flag some of your actions as important by returning true here
isActionImportant: action => action.type === StartupTypes.STARTUP,
// isActionImportant: action => action.type === StartupTypes.STARTUP,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaning to do that for like 6 months. haha.

if (__DEV__ && console.tron) {
api.addMonitor(console.tron.apisauce)
}

// ------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah, awesome!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have no headers now?

facebook/react-native#934 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open an issue if you’re having a problem? Headers are coming through fine. I haven’t tried on 0.54 though. I hear there are changes.

Copy link

@artem-russkikh artem-russkikh Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skellock tried on a new ignite app (RN 0.50.4), everything is ok

@GantMan
Copy link
Member

GantMan commented May 25, 2017

@skellock
Copy link
Contributor Author

@GantMan I added a DEV switch for that.

@skellock
Copy link
Contributor Author

I can also switch it to use the config settings as well.... or i can delete it.

Either way, this is all temporary until I write/find that babel plugin.

@skellock
Copy link
Contributor Author

Alright, have a look again. I just swept thru & cleaned up everything. Making sure we're behind a consistent switch.

@jamonholmgren jamonholmgren merged commit 6c43d76 into master May 25, 2017
@jamonholmgren jamonholmgren deleted the update-reactotron branch May 25, 2017 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled JS Exception: console.tron.overlay is not a function
4 participants