Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundles up ts typings with dts-bundle #309

Closed
wants to merge 1 commit into from
Closed

Conversation

jamonholmgren
Copy link
Member

Per discussion in #308, this bundles up the typescript types in one file using dts-bundle. Not sure how good the types are, but it does produce convincing output.

@jamonholmgren jamonholmgren requested a review from GantMan January 5, 2018 07:43
@skellock
Copy link
Contributor

skellock commented Jan 5, 2018

The .d.ts files that tsc will have relative import statements. That's how they connect all the files together. Your types in package.json will point to the top of that tree (often coming out of an index.ts file).

I wouldn't sweat chasing a bundled .d.ts. These are dev dependencies.

var dts = require('dts-bundle')

dts.bundle({
name: 'gluegun',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dat space dough

@GantMan
Copy link
Member

GantMan commented Jan 5, 2018

I'm agreeing with Steve. Unless you can show a significant benefit, I say drop the d.ts bundle. It's cool that it exists, but I highly doubt you're getting your technical debt's worth.

@jamonholmgren
Copy link
Member Author

No problem. This is apparently an area with a fair amount of disagreement over in TypeScript land, so I'll go with the de facto standard here with lots of files. (I like the cleanliness of 1 file, but agree in practice it won't have much of an impact).

@jamonholmgren jamonholmgren deleted the build/typings branch January 6, 2018 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants