IPROTO-265 Avoid byte[] allocation for buffer of OutputStream #333
Conversation
|
Note this is a subset of the original commit at 16ba83f so that we avoid the byte[] that is used to buffer writes between the TagWriter and OutputStream as many implementations may not need this. In fact it is much simpler to instead wrap the OutputStream with their own BufferOutputStream if they want. |
wburns
force-pushed
the
avoid_buffer_for_outputstream
branch
from
9e4d888
to
1451186
Compare
| @@ -154,7 +154,7 @@ public static ByteBuffer toWrappedByteBuffer(ImmutableSerializationContext ctx, | |||
| } | |||
|
|
|||
| public static void toWrappedStream(ImmutableSerializationContext ctx, OutputStream out, Object t) throws IOException { | |||
| toWrappedStream(ctx, out, t, DEFAULT_STREAM_BUFFER_SIZE); | |||
| WrappedMessage.write(ctx, TagWriterImpl.newInstance(ctx, out), t); | |||
There was a problem hiding this comment.
shouldn't be TagWriterImpl.newInstanceNoBuffer?
There was a problem hiding this comment.
Ah! I see you changed newInstance(ImmutableSerializationContext serCtx, OutputStream output).
So newInstanceNoBuffer is kind of duplicated/irrelevant at this point!?
There was a problem hiding this comment.
I was not aware of newInstanceNoBuffer! Yeah, no reason newInstance should ever use the buffered version imo. Updated to deprecate newInstanceNoBuffer as well.
wburns
force-pushed
the
avoid_buffer_for_outputstream
branch
from
1451186
to
9349a40
Compare
|
merged! thanks @wburns ! |
https://issues.redhat.com/browse/IPROTO-265