ISPN-346 Fix JSON for maps #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tristantarrant needs rebase. |
tristantarrant
force-pushed
the
IPROTO-346/jsonmap
branch
from
c6a7c1e
to
55d26d4
Compare
|
Rebased and added json > proto support for maps too |
pruivo
reviewed
Jul 3, 2024
| case SFIXED32 -> nestedWriter.writeSFixed32(1, Integer.parseInt(key)); | ||
| case SFIXED64 -> nestedWriter.writeSFixed64(1, Long.parseLong(key)); | ||
| case UINT32 -> nestedWriter.writeUInt32(1, Integer.parseInt(key)); | ||
| case UINT64 -> nestedWriter.writeUInt64(1, Long.parseLong(key)); |
There was a problem hiding this comment.
Those are not valid protobuf map keys. Only scalars are supported
|
merged! thanks @tristantarrant ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/IPROTO-346