add settings to enable/disable stopwords in analyzer #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib29ba3a7740cba49145f74b3417e45090bb23f34
medcl
reviewed
Apr 28, 2020
| @@ -34,6 +37,7 @@ public Configuration(Environment env,Settings settings) { | |||
| this.settings=settings; | |||
|
|
|||
| this.useSmart = settings.get("use_smart", "false").equals("true"); | |||
| this.useStopWords = settings.get("use_stopwords", "true").equals("true"); | |||
There was a problem hiding this comment.
please change this config name from use_lowercase to enable_lowercase , to better align with the below config;
|
please help to resolve the conflicts and add example usage in README , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, for some doc fields like project_name/table_name, the stopwords are expected to be indexed and searchable. so would like to add a switch to disable stopwords.