Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RESTful API Reference #908

Merged
merged 17 commits into from
May 27, 2024
Merged

Conversation

writinwaters
Copy link
Contributor

@writinwaters writinwaters commented May 23, 2024

What problem does this PR solve?

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Type of change

  • Documentation Update

@writinwaters writinwaters marked this pull request as draft May 23, 2024 11:37
@writinwaters writinwaters marked this pull request as ready for review May 26, 2024 15:17
@writinwaters
Copy link
Contributor Author

Validated and improved clarity of the API reference. I may have tempered with the intended meaning, please double check.

@writinwaters
Copy link
Contributor Author

writinwaters commented May 26, 2024

There is still room for improvement, for example, descriptions of the API behavior are still on the thin side. But I feel the current version is ready for initial publication.

Copy link
Contributor

@guoyuhao2330 guoyuhao2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/references/api.md Show resolved Hide resolved
docs/references/api.md Outdated Show resolved Hide resolved
docs/references/api.md Outdated Show resolved Hide resolved
docs/references/api.md Outdated Show resolved Hide resolved
@JinHai-CN
Copy link
Contributor

Add DEMO link at the first paragraph of README

@writinwaters writinwaters changed the title 0523 api Updated RESTful API Reference May 27, 2024
docs/references/api.md Outdated Show resolved Hide resolved
docs/references/api.md Outdated Show resolved Hide resolved
docs/references/api.md Outdated Show resolved Hide resolved
docs/references/api.md Outdated Show resolved Hide resolved

## Delete document
- Path: `/api/document`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path is also not a very proper word. Change it to: Request URI

@KevinHuSh KevinHuSh merged commit 65677f6 into infiniflow:main May 27, 2024
1 check passed
@guoyuhao2330 guoyuhao2330 mentioned this pull request May 27, 2024
1 task
KevinHuSh pushed a commit that referenced this pull request May 27, 2024
### What problem does this PR solve?

Update docnm_kwd to doc_name 
#908 

### Type of change


- [x] Refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants