Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VolcEngine - the current version supports SDK2 #885

Merged
merged 3 commits into from
May 23, 2024

Conversation

yungongzi
Copy link
Contributor

@yungongzi yungongzi commented May 22, 2024

  • The main idea is to assemble ak, sk, and ep_id into a dictionary and store it in the database api_key field
  • I don’t know much about the front-end, so I learned from Ollama, which may be redundant.

Configuration method

  • model name

  • Format requirements: {"VolcEngine model name":"endpoint_id"}

    • For example: {"Skylark-pro-32K":"ep-xxxxxxxxx"}
  • Volcano ACCESS_KEY

    • Format requirements: VOLC_ACCESSKEY of the volcano engine corresponding to the model
  • Volcano SECRET_KEY

    • Format requirements: VOLC_SECRETKEY of the volcano engine corresponding to the model

image

What problem does this PR solve?

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Type of change

  • New Feature (non-breaking change which adds functionality)

- 主要思路,将ak、sk、ep_id组装存储到数据库api_key字段
- 前端了解的少,参考Ollama代码,可能有冗余
@JinHai-CN
Copy link
Contributor

JinHai-CN commented May 22, 2024

Thank you for you contribution! We intend to create an international community, so we encourage using English for issues and pull requests. Would you please update the PR description and the code comments ?

@yungongzi yungongzi changed the title 增加对火山方舟大模型的支持-当前版本为对SDK2的支持 Add support for VolcEngine - the current version supports SDK2 May 22, 2024
@yungongzi
Copy link
Contributor Author

Thank you for you contribution! We intend to create an international community, so we encourage using English for issues and pull requests. Would you please update the PR description and the code comments ?

I have made modifications. Since this is my first PR, please give me some guidance.

Copy link
Contributor

@cike8899 cike8899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

@JinHai-CN JinHai-CN merged commit eb51ad7 into infiniflow:main May 23, 2024
1 check passed
@JinHai-CN JinHai-CN mentioned this pull request May 30, 2024
20 tasks
@dongjiashi
Copy link

Dear @yungongzi and all,

Since VolcEngine's latest model(Doubao series) and SDK v3 has been published for quiet a while, may I know if you considerate to make a new feature to support that?

AFAIK, the v3 SDK supports API_KEY, and the LLMs are named as Doubao-[pro|lite]-[4k|32k|128k].
Supporting this really helps.

Your sincerely.

@yungongzi
Copy link
Contributor Author

Dear @yungongzi and all,

Since VolcEngine's latest model(Doubao series) and SDK v3 has been published for quiet a while, may I know if you considerate to make a new feature to support that?

AFAIK, the v3 SDK supports API_KEY, and the LLMs are named as Doubao-[pro|lite]-[4k|32k|128k]. Supporting this really helps.

Your sincerely.

Ok, I'll try my best to finish.
However, the model name of VolcEngine v3 is still the EndpointID corresponding to different models, and the model name cannot be used directly【Doubao-[pro|lite]-[4k|32k|128k]】.
借虎先锋一句话:马了个巴子,这都V3改了一半儿啊!

@yungongzi yungongzi mentioned this pull request Aug 24, 2024
6 tasks
@dongjiashi
Copy link

Ok, I'll try my best to finish. However, the model name of VolcEngine v3 is still the EndpointID corresponding to different models, and the model name cannot be used directly【Doubao-[pro|lite]-[4k|32k|128k]】. 借虎先锋一句话:马了个巴子,这都V3改了一半儿啊!

Great! And thank you very much for your contribution!

Halfknow pushed a commit to Halfknow/ragflow that referenced this pull request Nov 13, 2024
…iflow#885)

- The main idea is to assemble **ak**, **sk**, and **ep_id** into a
dictionary and store it in the database **api_key** field
- I don’t know much about the front-end, so I learned from Ollama, which
may be redundant.

### Configuration method

- model name

- Format requirements: {"VolcEngine model name":"endpoint_id"}
    - For example: {"Skylark-pro-32K":"ep-xxxxxxxxx"}
    
- Volcano ACCESS_KEY
- Format requirements: VOLC_ACCESSKEY of the volcano engine
corresponding to the model

- Volcano SECRET_KEY
- Format requirements: VOLC_SECRETKEY of the volcano engine
corresponding to the model
    
### What problem does this PR solve?

_Briefly describe what this PR aims to solve. Include background context
that will help reviewers understand the purpose of the PR._

### Type of change

- [x] New Feature (non-breaking change which adds functionality)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants