Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Xinference #320

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Support Xinference #320

merged 1 commit into from
Apr 11, 2024

Conversation

KevinHuSh
Copy link
Collaborator

What problem does this PR solve?

Issue link:#299

Type of change

  • New Feature (non-breaking change which adds functionality)

@KevinHuSh KevinHuSh merged commit 91068ed into infiniflow:main Apr 11, 2024
Umpire2018
Umpire2018 reviewed Apr 12, 2024
View reviewed changes
rag/llm/chat_model.py
@@ -158,6 +158,28 @@ def chat(self, system, history, gen_conf):
return "**ERROR**: " + str(e), 0


class XinferenceChat(Base):
def __init__(self, key=None, model_name="", base_url=""):
Copy link

@Umpire2018 Umpire2018 Apr 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was me, i would use model_uid instead of model_name here because xinference requires model_uid. Reference: here.

I saw frontend have deal with it in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umpire2018 Umpire2018 Umpire2018 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KevinHuSh @Umpire2018