Enhance email validation: Allow top-level domains with 5 letters #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently singing up to ragflow using a mail-adress with associated top-level domains that have more than 4 chars will fail due to a regex validation that enforces just this. In our use case, we'd like to use e-mail addresses with `.swiss` top-level domains, which is a valid TLD associated with the country switzerland in the IANA root database. This change makes the validation accept 5-letter TLDs.
Halfknow
pushed a commit
to Halfknow/ragflow
that referenced
this pull request
Nov 11, 2024
…iniflow#2856) ### What problem does this PR solve? Currently singing up to ragflow using a mail-adress with associated top-level domains that have more than 4 chars will fail due to a regex validation that enforces just this. In our use case, we'd like to use e-mail addresses with `.swiss` top-level domains, which is a valid TLD associated with the country switzerland in the IANA root database. This change makes the validation accept 5-letter TLDs. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) - [x] Other (please describe): Making validation for lenient, accepting more valid input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently singing up to ragflow using a mail-adress with associated top-level domains that have more than 4 chars will fail due to a regex validation that enforces just this.
In our use case, we'd like to use e-mail addresses with
.swisstop-level domains, which is a valid TLD associated with the country switzerland in the IANA root database.This change makes the validation accept 5-letter TLDs.
Type of change