Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API doc: Correct Base URL and Dataset URL. #1444

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

cyhasuka
Copy link
Contributor

@cyhasuka cyhasuka commented Jul 9, 2024

The correct URL is http://<host_address>/v1/api , not http://<host_address>/api/v1 .

What problem does this PR solve?

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

The correct URL is http://<host_address>/v1/api , not http://<host_address>/api/v1 .
@@ -8,12 +8,12 @@ RAGFlow offers RESTful APIs for you to integrate its capabilities into third-par

## Base URL
```
http://<host_address>/api/v1/
http://<host_address>/v1/api/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your correction is right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I understand that in future releases the dataset URL will change to http://<host_address>/api/v1/dataset? Why doesn't it stay synchronized with the base URL?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Because we want to be consistent with others.

@KevinHuSh KevinHuSh merged commit 8964817 into infiniflow:main Jul 10, 2024
1 check passed
paresh2806 pushed a commit to paresh2806/ragflow that referenced this pull request Jul 11, 2024
The correct URL is http://<host_address>/v1/api , not
http://<host_address>/api/v1 .

### What problem does this PR solve?

### Type of change

- [x] Documentation Update

---------

Co-authored-by: Kevin Hu <[email protected]>
Halfknow pushed a commit to Halfknow/ragflow that referenced this pull request Nov 11, 2024
The correct URL is http://<host_address>/v1/api , not
http://<host_address>/api/v1 .

### What problem does this PR solve?

### Type of change

- [x] Documentation Update

---------

Co-authored-by: Kevin Hu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants