New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create list_dataset api and tests #1138

Merged

JinHai-CN merged 4 commits into infiniflow:main from cecilia-uu:list_dataset_api

Jun 17, 2024

Contributor

cecilia-uu commented Jun 12, 2024 •

edited

Loading

What problem does this PR solve?

This PR have completed both HTTP API and Python SDK for 'list_dataset". In addition, there are tests for it.

Type of change

New Feature (non-breaking change which adds functionality)


          create list_dataset api and tests

e7a0ce1

JinHai-CN reviewed

View reviewed changes

api/apps/dataset_api.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

api/apps/dataset_api.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

api/apps/dataset_api.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

sdk/__init__.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

sdk/python/__init__.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

sdk/python/__init__.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

sdk/python/ragflow/__init__.py Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

sdk/python/ragflow/ragflow.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

sdk/python/test/test_dataset.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

sdk/python/test/test_dataset.py Outdated Show resolved Hide resolved


          changed parameters for listing datasets, changed knowledgebase_servic…

62884f4

…e, added more tests and polished create_dataset api

JinHai-CN reviewed

View reviewed changes

sdk/python/test/test_dataset.py Outdated Show resolved Hide resolved

JinHai-CN reviewed

View reviewed changes

sdk/python/test/test_dataset.py Show resolved Hide resolved

JinHai-CN requested changes

View reviewed changes

Contributor

JinHai-CN left a comment

Test cases are not enough.

Contributor

JinHai-CN commented Jun 16, 2024

Please add these test cases in dataset_test.py:

No any knowledge base, expect list API to get empty result.
Create 100 knowledge base, expect list API will return 100 result with expected name.

cecilia-uu added 2 commits

June 17, 2024 09:36


          added two more tests and polished create_dataset method

0a1088b


          initial ragflow instance updated

883e76b

JinHai-CN merged commit 1eb4caf into infiniflow:main

1 check passed

cecilia-uu deleted the list_dataset_api branch

July 2, 2024 06:16

Halfknow pushed a commit to Halfknow/ragflow that referenced this pull request


          create list_dataset api and tests (infiniflow#1138)

24660e8

### What problem does this PR solve?

This PR have completed both HTTP API and Python SDK for 'list_dataset".
In addition, there are tests for it.

### Type of change

- [x] New Feature (non-breaking change which adds functionality)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet