Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: the var b shoud be b_ in the following code #917

Closed
chinamerp opened this issue May 24, 2024 · 1 comment
Closed

[Question]: the var b shoud be b_ in the following code #917

chinamerp opened this issue May 24, 2024 · 1 comment
Labels
question Further information is requested

Comments

@chinamerp
Copy link
Contributor

chinamerp commented May 24, 2024

Describe your problem

(https://github.com/infiniflow/ragflow/blob/c0d71adaa2c6c8d5b54d2ec5e4fe51ad0ea07c01/deepdoc/parser/pdf_parser.py#L395C16-L395C56)

            concatting_feats = [
                b["text"].strip()[-1] in ",;:'\",、‘“;:-",
                len(b["text"].strip()) > 1 and b["text"].strip(
                )[-2] in ",;:'\",‘“、;:",
                b["text"].strip()[0] in "。;?!?”)),,、:",   ### should be b_?
            ]
@chinamerp chinamerp added the question Further information is requested label May 24, 2024
@KevinHuSh
Copy link
Collaborator

KevinHuSh commented May 27, 2024

Yes, you could submit a PR.
Thanks!

KevinHuSh added a commit to KevinHuSh/ragflow that referenced this issue May 28, 2024
@KevinHuSh KevinHuSh mentioned this issue May 28, 2024
1 task
Halfknow pushed a commit to Halfknow/ragflow that referenced this issue Nov 13, 2024
### What problem does this PR solve?

infiniflow#917 
infiniflow#915

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants