-
Notifications
You must be signed in to change notification settings - Fork 1
Fork off node-segfault-handler #465
Comments
@Croydon said he would like to do the Docker/Travis fiddling I will attach the summary from Riot here,
Consider the naming scheme from https://github.com/mapbox/node-pre-gyp#package_name to upload binaries |
@Fohlen Is the binary Node.js and OS version specific? |
@Croydon unfortanly yes. For Ubuntu 12 and 14 it might not matter because of (for older dists) GCC4 / GCC5 (for newer dists). Anyhow compiling the dependencies needs to be done at least for every different Node.js version since extensions are |
Although the segfault-handler is very useful in the case of errors we can leave it out for 0.9. |
I will soon make time to work on this (just to make that clear). But I'm also pretty sure that this decision will hunt us in the future. Do we really want to maintain it permanentely, can we maintain it permanentely and is there really no alternative? We are not the only ones who want to invest Node.js app crashes, what are all these projects doing? |
I set up Docker containers with Ubuntu Xenial with Node.js 6 (LTS) and Node.js 8. @Fohlen Are you already familiar with node-pre-gyp and how to use it? |
@a-teammate Where can I find your fixes? |
On a second look it's rather insane to fork this off and maintaince it by ourselves. We should look for other solutions. |
This is very true.. |
There is a decision to move away from Node, therefore we don't need node-segfault-handler anymore and even if, we should definitely not maintain our own node segfault handler. |
Fork off node-segfault-handler and package with
node-pre-gyp
to work around #456To-Do:
and distros (Trusty)@inexorgame/segfault-handler
to replacesegfault-handler
in flexThe text was updated successfully, but these errors were encountered: