Skip to content
This repository has been archived by the owner on Oct 11, 2020. It is now read-only.

Fork off node-segfault-handler #465

Closed
3 of 9 tasks
Fohlen opened this issue Jul 31, 2017 · 10 comments
Closed
3 of 9 tasks

Fork off node-segfault-handler #465

Fohlen opened this issue Jul 31, 2017 · 10 comments

Comments

@Fohlen
Copy link

Fohlen commented Jul 31, 2017

Fork off node-segfault-handler and package with node-pre-gyp to work around #456

To-Do:

  • Fork the repository and rename stuff
  • Upload binaries to Bintray
    • Use AppVeyor for Windows
    • Use a Docker Xenial container with Node.js via Travis for Xenial binaries
      • Add a matrix for multiple node versions and distros (Trusty)
    • If not too hard, also build OSX binaries (this will probably greatly reward in the future, as people then use our module, it's quiet popular among OSX, afaik)
  • Merge open pull requests from upstream, if useful
  • Merge @a-teammate fixes
  • Use @inexorgame/segfault-handler to replace segfault-handler in flex
@Fohlen
Copy link
Author

Fohlen commented Jul 31, 2017

@Croydon said he would like to do the Docker/Travis fiddling

I will attach the summary from Riot here,

  • run npm install && npm install node-gyp -g
  • run node-gyp && cd build && make
  • there will be some binary blobs in build/Release, namely the segfault-handler.node that need to be uploaded to Bintray

Consider the naming scheme from https://github.com/mapbox/node-pre-gyp#package_name to upload binaries

@Croydon
Copy link
Contributor

Croydon commented Sep 11, 2017

Add a matrix for multiple node versions and distros (Trusty), (optional)

@Fohlen Is the binary Node.js and OS version specific?

@Fohlen
Copy link
Author

Fohlen commented Sep 11, 2017

@Croydon unfortanly yes. For Ubuntu 12 and 14 it might not matter because of (for older dists) GCC4 / GCC5 (for newer dists). Anyhow compiling the dependencies needs to be done at least for every different Node.js version since extensions are NODE_ABI dependant

@a-teammate
Copy link
Contributor

Although the segfault-handler is very useful in the case of errors we can leave it out for 0.9.
I will still provide my fixes and am hoping that @Croydon could upload the binaries for 0.10.

@a-teammate a-teammate modified the milestones: 0.9.0-alpha, 0.10.0-alpha Sep 25, 2017
@Croydon
Copy link
Contributor

Croydon commented Oct 3, 2017

I will soon make time to work on this (just to make that clear).

But I'm also pretty sure that this decision will hunt us in the future. Do we really want to maintain it permanentely, can we maintain it permanentely and is there really no alternative?

We are not the only ones who want to invest Node.js app crashes, what are all these projects doing?

@Croydon
Copy link
Contributor

Croydon commented Oct 4, 2017

I set up Docker containers with Ubuntu Xenial with Node.js 6 (LTS) and Node.js 8.
It compiles successfully. https://travis-ci.org/inexorgame/node-segfault-handler/builds/283043535

@Fohlen Are you already familiar with node-pre-gyp and how to use it?

@Croydon
Copy link
Contributor

Croydon commented Oct 4, 2017

@a-teammate Where can I find your fixes?

@Croydon
Copy link
Contributor

Croydon commented Jul 7, 2018

On a second look it's rather insane to fork this off and maintaince it by ourselves. We should look for other solutions.

@a-teammate
Copy link
Contributor

This is very true..

@Croydon Croydon removed their assignment Jul 19, 2018
@Croydon
Copy link
Contributor

Croydon commented Dec 31, 2018

There is a decision to move away from Node, therefore we don't need node-segfault-handler anymore and even if, we should definitely not maintain our own node segfault handler.

@Croydon Croydon closed this as completed Dec 31, 2018
@ghost ghost removed the org:planned label Dec 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.