Skip to content
This repository has been archived by the owner on Oct 11, 2020. It is now read-only.

inexor-flex depends on node-gyp needs python as an end-user dependency #456

Closed
Fohlen opened this issue Jul 23, 2017 · 11 comments
Closed

inexor-flex depends on node-gyp needs python as an end-user dependency #456

Fohlen opened this issue Jul 23, 2017 · 11 comments

Comments

@Fohlen
Copy link

Fohlen commented Jul 23, 2017

Title says it all.
Since python 2.7 is shipped by default on almost every linux and OSX that's not too bad. For windows, that could do it:

https://github.com/felixrieseberg/windows-build-tools

@Fohlen Fohlen added this to the 0.9.0-alpha milestone Jul 23, 2017
@Fohlen
Copy link
Author

Fohlen commented Jul 24, 2017

this is also related to #269
@terencode I will test wether the above module works, and if so, we can add it to the install instructions for Windows

@Fohlen
Copy link
Author

Fohlen commented Jul 24, 2017

will be solved by #277

@Croydon
Copy link
Contributor

Croydon commented Jul 24, 2017

Is there no way we can get rid of Python as an end-user dep?

@Fohlen
Copy link
Author

Fohlen commented Jul 24, 2017

Unless you want to build gyp, a c++ compiler, cmake and python as virtual packages:
no.

@Croydon
Copy link
Contributor

Croydon commented Jul 24, 2017

Could you please explain the dep tree? Why do we need node-gyp, therefore gyp..?

@Fohlen
Copy link
Author

Fohlen commented Jul 24, 2017

grpc, segfault handler build via node-gyp, build via gyp.
gyp is on top of python
gyp also requires a compiler-toolset (what you would call build-essential on Debian)

@a-teammate
Copy link
Contributor

node-gyp is used by two dependencies (one which is essential: grpc and one which is really useful: segfault-handler) which are build in c++ rather than js but have node.js bindings.
node-gyp is a meta-build tool comparable to CMake but written in python and deprecated (its underlying technology was created by google: GYP).
It's also not python 3.x compatible.

The suggested tool looks pretty good.
You are probably right @Fohlen to let the installer (#277) install the windows-build-tools globally first (it's not becoming apparent though how to use this module to build npm install cleanly afterwards, or is it?

@Fohlen
Copy link
Author

Fohlen commented Jul 29, 2017

@a-teammate and I agreed to fork segfault-handler and pre-compile it via node-pre-gyp
That way

  • we squash bugs in the segfault lib
  • get rid of Python as an end dependency

@Croydon
Copy link
Contributor

Croydon commented Jul 30, 2017

FYI: We are not the only ones annoyed by the situation

nodejs/NG#24
https://github.com/cmake-js/cmake-js
nodejs/node-gyp#960

@Fohlen
Copy link
Author

Fohlen commented Sep 1, 2017

This issue will be resolved by #465 indefinitely

@a-teammate
Copy link
Contributor

Since we removed the node-segfault-handler temporarily, we can close this.
As we finished #465 we can enable the handling of segfault errors in native node modules again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants