Add support for creating LDAP clients from existing TcpStream/UnixStream. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszkj
changed the title
TcpStream and `……UnixStream`. That's allows to create LDAP client from file descriptor and handle connection (with ssl) in sandboxed process.
|
FYI: I'll be mostly offline for the next ten days or so, and I won't be able to handle any issues. |
|
[Better late than never, eh?] Thanks for the PR, its concept is a worthwhile addition to the library and I'll be happy to have it included; however, I'm not keen to further complicate the connection API, which already has a lot of variations. I would prefer to place the stream into |
inejge
added a commit
that referenced
this pull request
Oct 23, 2024
Per issue #132 discussion: the approach in 2697ae complicates the API, the solution will be via LdapConnSettings, but I want to record the contribution since the basic idea is sound and useful.
|
Merged and reverted to rework with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow creating Ldap client (sync and async) from exiting Tcp/Unix streams.
That's allows to create LDAP client from file descriptor and handle connection (with ssl) in sandboxed process.
Example scenario: