Skip to content

Conversation

@gaohao95
Copy link
Contributor

@gaohao95 gaohao95 commented Oct 9, 2023

This PR implements the distributed layer potential evaluation using MPI. On the high level, it broadcasts the necessary geometry data from the root rank to the worker rank, and each worker rank constructs a local copy of the geometry data independently.

❗ Depends on inducer/boxtree#93.

Comment on lines +41 to +46
global_traversal: Any
centers: Any
expansion_radii: Any
global_qbx_centers: Any
qbx_center_to_target_box: Any
non_qbx_box_target_lists: Any
center_to_tree_targets: Any
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually: improve type annotation

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a 2D and a 3D test.

fmm_backend=fmm_backend,
**kwargs)
else:
self._use_target_specific_qbx = _use_target_specific_qbx
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document that this is an internal code path for workers.

@gaohao95 gaohao95 changed the title Implement distributed evaluation Implement distributed layer potential evaluation Aug 26, 2024
git+https://github.com/inducer/islpy.git#egg=islpy
git+https://github.com/inducer/loopy.git#egg=loopy
git+https://github.com/inducer/boxtree.git#egg=boxtree
git+https://github.com/gaohao95/boxtree.git@dist-pytential#egg=boxtree
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reverted back after inducer/boxtree#93 lands.

@gaohao95 gaohao95 marked this pull request as ready for review August 26, 2024 16:32
@inducer
Copy link
Owner

inducer commented Aug 26, 2024

#239 should get rid of the mypy problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants