Skip to content

Stokes/Elasticity using biharmonic/Laplace #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stokes/Elasticity using biharmonic/Laplace #162

wants to merge 1 commit into from

Conversation

@isuruf
Copy link
Collaborator

@isuruf isuruf commented Jun 27, 2022 •
edited
Loading

  • Point sumpy back to main

inducer
inducer reviewed Jun 27, 2022
View reviewed changes
@isuruf isuruf force-pushed the stokes_biharmonic2 branch 4 times, most recently from 95a898d to acc5ae0 Compare June 27, 2022 21:26
@alexfikl
Copy link
Collaborator

alexfikl commented Aug 4, 2022

@isuruf I've been using #29 for my stuff. Should I switch to this? Does it contain any fixes or is it just a clean squash on top of main?

@isuruf
Copy link
Collaborator Author

isuruf commented Aug 4, 2022

@alexfikl, this PR has only parts of #29 so that it is easier to review. I'm not sure if this PR has all the features that you need. Probably not.

inducer
inducer reviewed Aug 8, 2022
View reviewed changes
pytential/symbolic/elasticity.py Outdated
@@ -0,0 +1,166 @@
__copyright__ = "Copyright (C) 2021 Isuru Fernando"
Copy link
Owner

@inducer inducer Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be good to have CalculusPatch tests to ensure that PDE rediual for Stokes and elasticity is zero.

Copy link
Collaborator Author

@isuruf isuruf Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test to check the stokes PDE in a9931e5 and elasticity in bb31471

Copy link
Owner

@inducer inducer Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's technically not testing the Stokes potential, it's testing pytential-computed derivatives thereof.

inducer
inducer reviewed Aug 22, 2022
View reviewed changes
alexfikl
alexfikl reviewed Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@alexfikl alexfikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bunch of nitpicks to pytential.symbolic.stokes (mostly based on how I've been using the new stuff). Many are ignorable, so feel free!

The main thing that bothered me while going through it was the nu_sym everywhere. It feels like that should be handled in elasticity so the user never gets a chance to pass nu_sym=3 from the Stokes wrappers.

@isuruf isuruf force-pushed the stokes_biharmonic2 branch from fec9eab to ee09dbd Compare September 5, 2022 22:10
@isuruf
Copy link
Collaborator Author

isuruf commented Sep 8, 2022

@inducer, @alexfikl, this is ready for another round of reviews.

alexfikl
alexfikl reviewed Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@alexfikl alexfikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch more nitpicks in pde.system_utils this time around :D

This is looking very cool!

inducer
inducer reviewed Sep 12, 2022
View reviewed changes
pytential/symbolic/elasticity.py Outdated
@@ -0,0 +1,166 @@
__copyright__ = "Copyright (C) 2021 Isuru Fernando"
Copy link
Owner

@inducer inducer Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's technically not testing the Stokes potential, it's testing pytential-computed derivatives thereof.

pytential/symbolic/elasticity.py Outdated
@@ -0,0 +1,166 @@
__copyright__ = "Copyright (C) 2021 Isuru Fernando"
Copy link
Owner

@inducer inducer Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull the docs of this into like an "internals" chapter? internals.rst?

isuruf
isuruf commented Sep 14, 2022
View reviewed changes
inducer
inducer reviewed Nov 21, 2022
View reviewed changes
inducer
inducer reviewed Nov 21, 2022
View reviewed changes
@isuruf isuruf force-pushed the stokes_biharmonic2 branch 2 times, most recently from f7b661d to d34f787 Compare November 23, 2022 15:06
@isuruf
Copy link
Collaborator Author

isuruf commented Nov 23, 2022

This is ready for another round of reviews

alexfikl
alexfikl approved these changes Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@alexfikl alexfikl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of nitpicks while reading this again. I don't think any of them are stoppers of any sort, so go for it when you and @inducer are done! 🚀

Also, thanks for all this Stokes performance work! It's been immensely helpful in the past two-ish years!

inducer
inducer reviewed Dec 5, 2022
View reviewed changes
inducer
inducer reviewed Dec 12, 2022
View reviewed changes
@isuruf isuruf requested a review from inducer December 14, 2022 17:59
@isuruf isuruf force-pushed the stokes_biharmonic2 branch from 748329d to ae1333c Compare December 19, 2022 18:26
inducer
inducer reviewed Dec 19, 2022
View reviewed changes
@isuruf isuruf force-pushed the stokes_biharmonic2 branch from 681b73d to c4173e1 Compare December 20, 2022 03:48
@inducer
Copy link
Owner

inducer commented Dec 20, 2022

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

@isuruf
Copy link
Collaborator Author

isuruf commented Dec 28, 2022

@inducer, ready for a review

@inducer inducer force-pushed the stokes_biharmonic2 branch from 73db2b5 to e689c53 Compare January 11, 2023 23:50
@inducer inducer force-pushed the stokes_biharmonic2 branch from a6672a5 to 9dc1614 Compare January 26, 2023 00:51
@isuruf isuruf force-pushed the stokes_biharmonic2 branch from 9dc1614 to c3faffe Compare March 23, 2023 19:01
@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch 2 times, most recently from fa9287e to 1f4ef5c Compare March 15, 2024 06:57
@alexfikl
Copy link
Collaborator

alexfikl commented Mar 15, 2024 •
edited
Loading

@inducer Assuming the tests pass this time around, this is looking pretty good to me! I looked over the remaining open comments and most of them were doc related, so I gave the docs another read and fixed some things here and there in 2690073.

Let me know if there's anything else that could be fixed!

EDIT: The tests on macOS seem to consistently fail with some version of OSError: [Errno 28] No space left on device. Not quite sure what that's about..

@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch 2 times, most recently from 6870dd7 to 37faea0 Compare March 15, 2024 14:50
@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch from 37faea0 to 0c06602 Compare July 6, 2024 06:45
@alexfikl alexfikl mentioned this pull request Jul 19, 2024
Merged
@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch from 0c06602 to d31b59a Compare July 22, 2024 06:09
@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch 2 times, most recently from 62c20a8 to 6046a29 Compare November 18, 2024 14:04
@alexfikl alexfikl mentioned this pull request Nov 18, 2024
Merged
@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch 3 times, most recently from e0f8b7d to 19415b4 Compare December 17, 2024 08:28
@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch from 19415b4 to d1db7f6 Compare January 9, 2025 14:24
@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch from d1db7f6 to 88cb6ca Compare May 2, 2025 11:42
@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch 3 times, most recently from c80cb49 to 0ff1e89 Compare September 20, 2025 17:45
@alexfikl
Copy link
Collaborator

alexfikl commented Sep 20, 2025

@inducer Went ahead and squashed this into a single commit to make it easier to rebase/merge from main.

There seem to be some new and exciting test failures in there too (possibly because of a bad rebase). I'll look into those next week or so.

@alexfikl alexfikl force-pushed the stokes_biharmonic2 branch 2 times, most recently from 2758185 to 2145138 Compare September 21, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inducer inducer inducer left review comments

@alexfikl alexfikl alexfikl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isuruf @alexfikl @inducer