Introduce algebraic transformations for sum-reduction operations #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
changed the title
kaushikcfd
changed the title
kaushikcfd
force-pushed
the
redn_algebraic_transforms
branch
3 times, most recently
from
9f2286d
to
7f51390
Compare
kaushikcfd
force-pushed
the
redn_algebraic_transforms
branch
2 times, most recently
from
aa470e3
to
4995215
Compare
kaushikcfd
force-pushed
the
redn_algebraic_transforms
branch
from
4995215
to
e83ca29
Compare
inducer
reviewed
Dec 19, 2022
Comment on lines
+86
to
+88
| .. autofunction:: hoist_invariant_multiplicative_terms_in_sum_reduction | ||
|
|
||
| .. autofunction:: extract_multiplicative_terms_in_sum_reduction_as_subst |
There was a problem hiding this comment.
Suggested change
| .. autofunction:: hoist_invariant_multiplicative_terms_in_sum_reduction | |
| .. autofunction:: extract_multiplicative_terms_in_sum_reduction_as_subst | |
| .. automodule:: loopy.transform.reduction |
| return super().map_reduction(expr) | ||
|
|
||
|
|
||
| def hoist_invariant_multiplicative_terms_in_sum_reduction( |
There was a problem hiding this comment.
Name?
- inverse of "distribute"
- "out of"
| :arg within: A match expression understood by :func:`loopy.match.parse_match` | ||
| that specifies the instructions over which the transformation is to be | ||
| performed. | ||
| """ |
There was a problem hiding this comment.
Add example?
out[j] = sum(i, x[i]*y[j])
after hoisting wrt i:
out[j] = y[j]*sum(i, x[i])
| return super().map_reduction(expr) | ||
|
|
||
|
|
||
| def hoist_invariant_multiplicative_terms_in_sum_reduction( |
There was a problem hiding this comment.
Make this work on TranslationUnit?
| within: Any = None | ||
| ) -> LoopKernel: | ||
| """ | ||
| Hoists loop-invariant multiplicative terms in a sum-reduction expression. |
There was a problem hiding this comment.
Specify how this interacts with reductions with multiple inames.
|
|
||
|
|
||
| def extract_multiplicative_terms_in_sum_reduction_as_subst( | ||
| kernel: LoopKernel, |
Comment on lines
+234
to
+235
| arguments: Sequence[p.Expression], | ||
| terms_filter: Callable[[p.Expression], bool], |
There was a problem hiding this comment.
Suggested change
| arguments: Sequence[p.Expression], | |
| terms_filter: Callable[[p.Expression], bool], | |
| arguments: Sequence[ExpressionT], | |
| terms_filter: Callable[[ExpressionT], bool], |
|
|
||
| # {{{ extract_multiplicative_terms_in_sum_reduction_as_subst | ||
|
|
||
| class ContainsSumReduction(CombineMapper): |
There was a problem hiding this comment.
Can this be done by simply attempting the transformation (without checking first) and aborting if there's ambiguity? (That would make this guy redundant, possibly.)
| return super().map_reduction(expr) | ||
|
|
||
|
|
||
| def extract_multiplicative_terms_in_sum_reduction_as_subst( |
There was a problem hiding this comment.
Does the outer reduction matter?
| return super().map_reduction(expr) | ||
|
|
||
|
|
||
| def hoist_invariant_multiplicative_terms_in_sum_reduction( |
There was a problem hiding this comment.
What about other operations that satisfy a distributive property? (Specify classes maybe? We don't need to enumerate things that obey the distributive law. We can't, not comprehensively, anyway.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function signature for the transforms aren't finalized yet. I'm happy to make changes to these with help from the reviewers.
Draft because: