Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C vecextensions target] #577

Closed
wants to merge 7 commits into from
Closed

[C vecextensions target] #577

wants to merge 7 commits into from

Conversation

sv2518
Copy link
Contributor

@sv2518 sv2518 commented Mar 11, 2022

These are two fixes

  1. for vectorising conditionals
  2. for vectorising sums and products containing function calls (like math functions)

kaushikcfd
kaushikcfd approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions. We can merge this after that, thanks!

loopy/expression.py Outdated Show resolved Hide resolved
loopy/expression.py Show resolved Hide resolved
@sv2518 @kaushikcfd
Error with message in map_if
2ce4f6f 
Co-authored-by: Kaushik Kulkarni <[email protected]>
@kaushikcfd
Copy link
Collaborator

To keep a clean commit history in #557, manually pushed this patch over there. Thanks! (Closing this as it was merged manually)

@kaushikcfd kaushikcfd closed this Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikcfd kaushikcfd kaushikcfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sv2518 @kaushikcfd