Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements lp.rename_inames #512

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Implements lp.rename_inames #512

merged 2 commits into from
Dec 29, 2021

Conversation

kaushikcfd
Copy link
Collaborator

Q. Why not use rename_iname repeatedly?
A. That would lead to multiple traversals of the IR and hence would bump up the operation complexity of certain transformations like Loop Fusion.

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mostly LGTM, only a few small wrinkles.

loopy/transform/iname.py Show resolved Hide resolved
loopy/transform/iname.py Show resolved Hide resolved
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I found a few superficial things. This is good to go once those are addressed.

loopy/transform/iname.py Show resolved Hide resolved
loopy/transform/iname.py Outdated Show resolved Hide resolved
loopy/transform/iname.py Show resolved Hide resolved
loopy/transform/iname.py Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Dec 29, 2021

Thanks! Looks great, in it goes.

@inducer inducer merged commit 14ae879 into main Dec 29, 2021
@inducer inducer deleted the rename_inames branch December 29, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants