-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using pybind's implicit __hash__
#103
base: main
Are you sure you want to change the base?
Conversation
d6d2606
to
25d8116
Compare
The SSL certificate on https://gmplib.org/ is broken, breaking all the wheel builds. It looks like they're aware of it. |
Thanks! Looks like most of loopy's errors come from def _isl_space_get_hash(x):
return hash((x.dim()), x.params()))
Space.__hash__ = _isl_space_get_hash It is unlikely that ISL will accept a corresponding native function as this defines new private API without any users. |
c1cee84
to
aba6644
Compare
@isuruf Was there a big reason why we used |
aba6644
to
5c1feba
Compare
So... it turns out that this is what has kept inducer/loopy#576 from biting as hard as it deserved to. https://gist.github.com/inducer/9eb97cb5a6064baee63d0ef64233ee3b together with this patch to loopy illustrates the issue: diff --git a/loopy/kernel/tools.py b/loopy/kernel/tools.py
index 99f5f350..32e11eba 100644
--- a/loopy/kernel/tools.py
+++ b/loopy/kernel/tools.py
@@ -355,6 +355,7 @@ class SetOperationCacheManager:
for bkt_set, result in bucket:
if set_.plain_is_equal(bkt_set):
+ assert result == op(set_, *args)
return result
result = op(set_, *args) |
I was thinking I could make a quick PR to loopy which would also add the condition |
Nope. |
No description provided.