Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nlohmann/json to list of indi-qhy dependencies #987

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

cgobat
Copy link
Contributor

@cgobat cgobat commented Oct 7, 2024

I initially got this error when trying to cmake -DCMAKE_INSTALL_PREFIX=/usr . in indi-qhy:

CMake Error at CMakeLists.txt:20 (find_package):
  By not providing "Findnlohmann_json.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "nlohmann_json", but CMake did not find one.

  Could not find a package configuration file provided by "nlohmann_json"
  with any of the following names:

    nlohmann_jsonConfig.cmake
    nlohmann_json-config.cmake

  Add the installation prefix of "nlohmann_json" to CMAKE_PREFIX_PATH or set
  "nlohmann_json_DIR" to a directory containing one of the above files.  If
  "nlohmann_json" provides a separate development package or SDK, be sure it
  has been installed.

After running a sudo apt install nlohmann-json3-dev, the above command worked just fine.

This PR adds this currently unmentioned dependency to the requirements list in the indi-qhy README file.

@cgobat
Copy link
Contributor Author

cgobat commented Oct 7, 2024

I also wanted to check whether the version requirement of INDI≥1.9.6 stated here:

+ INDI >= v1.9.6 (http://www.indilib.org)

is still correct. I got some strange errors later on in the compilation process that made it seem like my main INDI library installation was out of date. I have v1.9.9 installed.

@cgobat
Copy link
Contributor Author

cgobat commented Oct 7, 2024

Indeed, after uninstalling 1.9.9 and compiling/installing 2.1.0, the QHY driver builds just fine. So it would seem that the specified 1.9.6 minimum version is out of date. I can't say for sure what the minimum supported version actually is, but if I had to guess I would imagine it is 2.0.

If anyone knows the answer I'm happy to tack that change on to this PR as well.

@knro
Copy link
Collaborator

knro commented Oct 7, 2024

Right, everything should actually be updated to require INDI 2.1.0

@knro knro merged commit 0d799e0 into indilib:master Oct 8, 2024
3 of 4 checks passed
@cgobat cgobat deleted the add-qhy-dep branch October 8, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants