Added Debian files packages files and minor updates to catch when PWM is zero. #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial version of AStarBox as a 3rd-party driver.
New version detects if there is a problem or not with the I2C connection. Also, changed the names to be consistent with Rodolphe's files. (AStarBox vs CAStarBox), and changed astarbox to indi-astarbox.
Update to improve format.
Again change format.
Formatting again
I hope I have this right now!
Called openAllPorts into connect so can use results to indicate whether connection successful or not. Moved getPortPWM for ports 5 and 6 into connect too - when in openAllPports m_bLinked was false at that point so no values collected. Now called after m_bLlinked is true so that values are collected.
Merged Rodolphe's updates and mine. m_bPortsOpen is tested before opening all ports, but getting PWM5 and 6 is now in connect.
Replaced 5 and 6 by their ENUMS instead for consistency.
Previously, setting PWM to zero turned the port off. However, this prevented the status from being read so that if changed elsewhere, it would not be picked up. Now, the ports are left on though with power of zero (same as turned off from a physical perspective). Also, tidied up the return codes from setPortPWMDutyCyclePercent since this returns an integer rather than a bool,
First pass debian package. Copied from indi-asi-power.
Changed to refer to indi-astarbox, rather than indi-air-power.
Updated channgelog - changed time from +100 to +0100 to put it in the correct format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Debian packages. Also, the UI would not pick up changes when the PWM was initially zero. Changed logic for this edge case.