Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Atik SDK to 2023.07.14.1456. #817

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

TallFurryMan
Copy link
Contributor

No description provided.

@TallFurryMan
Copy link
Contributor Author

I did not pick the master branch from the right repository 😑

@knro
Copy link
Collaborator

knro commented Jul 31, 2023

Shall I close this and then you can resubmit again?

@TallFurryMan
Copy link
Contributor Author

I'll fix this during lunchtime.

@knro
Copy link
Collaborator

knro commented Jul 31, 2023

@TallFurryMan Any update?

@TallFurryMan
Copy link
Contributor Author

I have a question about 4ad082b, what was done there to MacOS files? Is there a specific change I should do before pushing?

@knro
Copy link
Collaborator

knro commented Jul 31, 2023

no, I will take care of that after you push (basically run it on MacOS to fix some links)

@TallFurryMan TallFurryMan force-pushed the improve__atik_20230704 branch from ac6af37 to b3f3708 Compare July 31, 2023 14:40
@knro
Copy link
Collaborator

knro commented Jul 31, 2023

missing header?

@knro
Copy link
Collaborator

knro commented Jul 31, 2023

CMakelists.txt should probably install the new header.

@TallFurryMan
Copy link
Contributor Author

Versions are missing, and there's a new header that I didn't take into account in cmakelists. Not going very fast here 😅

@TallFurryMan TallFurryMan force-pushed the improve__atik_20230704 branch from b3f3708 to a0b5ec2 Compare July 31, 2023 14:59
@TallFurryMan
Copy link
Contributor Author

Good to go. I might be able to test this tonight, but it means updating quite a lot of elements in the obs and rebuilding some for i386 and some for x64.

@knro knro merged commit 00a322d into indilib:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants