SVBONY CCD firmware and SDK version information logs added #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knro
reviewed
Jul 2, 2023
indi-svbony/svbony_ccd.cpp
Outdated
| LOGF_INFO("Camera Firmware Version:%s", cameraFirmwareVersion); | ||
| } | ||
| else { | ||
| LOG_ERROR("Error, getting Camera Firmware Version failed.\n"); |
There was a problem hiding this comment.
I committed it with newline code removed form LOG_ERROR.
knro
reviewed
Jul 2, 2023
Comment on lines
+113
to
+115
| char cameraFirmwareVersion[65]; | ||
| // SVBONY Camera SDK version number | ||
| const char* SDKVersion; |
There was a problem hiding this comment.
If you're only using this to report version information once in Connect, is there a reason to keep it as class variable? or is this used elsewhere?
There was a problem hiding this comment.
If EKOS is used, this information is output to the log and need not be retained.
If non-EKOS clients use it without logging, I will retain this information for reference when debugging.
I also plan to display this information in the INDI control panel in the future, so we decided to keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to SVBONYCCD::Connect() to output the version of SVBONY Camera's firmware and SDK as information log.
This information is used when users inquire about issues.