Skip to content

IWF-118: Refactor package structure #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 25, 2024
Merged

IWF-118: Refactor package structure #433

merged 9 commits into from
Sep 25, 2024

Conversation

longquanzheng
Copy link
Contributor

No description provided.

@longquanzheng longquanzheng marked this pull request as ready for review September 25, 2024 16:33
@longquanzheng longquanzheng changed the title Refactor package structure IWF-118: Refactor package structure Sep 25, 2024
@lwolczynski
Copy link
Contributor

lwolczynski commented Sep 25, 2024

Do we need the "All tests" action? It seems to me like we are running ITs against Temporal and Cadence twice.

Once in "Temporal Integration Test" & "Candence Integration Test", and once in the "All tests"

@longquanzheng
Copy link
Contributor Author

Do we need the "All tests" action? It seems to me like we are running ITs against Temporal and Cadence twice.

Once in "Temporal Integration Test" & "Candence Integration Test", and once in the "All tests"

Good question!
We need all tests because we need a single coverage report to calculate the coverage for all the tests that we have.

So the temporal/cadence/unit tests are actually redudunt. They are needed because running this all tests is usually taking a ver long time. Sometimes it's much better to see the failure at unit tests/temporal/cadence tests

@longquanzheng longquanzheng merged commit d9321af into main Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor refactoring: move replay test to a different folder. Move config.go to top level config folder
2 participants