IWF-125: Limit error size return from API #429
Merged
+837
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| errType = "1st-attempt-failure" | ||
| } else { |
There was a problem hiding this comment.
Nit: maybe nice to create a small func for the repeated code
stevo89519
reviewed
Sep 24, 2024
| @@ -88,3 +94,141 @@ func createCommands() ([]iwfidl.TimerCommand, []iwfidl.SignalCommand, []iwfidl.I | |||
| } | |||
| return validTimerCommands, validSignalCommands, internalCommands | |||
| } | |||
|
|
|||
| func TestComposeHttpError_LocalActivity_LongErrorResponse(t *testing.T) { | |||
There was a problem hiding this comment.
Some of these test initializations are using duplicated logic as well. It'd be nice if these were consolidated. Maybe a function that takes the repeat length and returns the httpResp?
There was a problem hiding this comment.
I'll try to extract as much logic a to helper as I can
stevo89519
approved these changes
Sep 24, 2024
longquanzheng
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.