Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use omitempty for start workflow input #370

Merged
merged 2 commits into from
Feb 22, 2024

nix

2d468fd
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

use omitempty for start workflow input #370

nix
2d468fd
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci succeeded Feb 22, 2024 in 0s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (24)

service/common/utils/utils.go|48 col 20| S1024: should use time.Until instead of t.Sub(time.Now()) (gosimple)
service/common/log/tag/interface.go|59 col 6| func newInt32 is unused (unused)
service/common/log/tag/interface.go|78 col 6| func newDurationTag is unused (unused)
service/common/log/tag/interface.go|102 col 6| func newPredefinedDynamicTag is unused (unused)
service/common/log/loggerimpl/logger_test.go|109 col 16| Error return value of zapLogger.Sync is not checked (errcheck)
service/common/log/loggerimpl/logger.go|55 col 25| copylocks: NewLoggerForTest passes lock by value: github.com/stretchr/testify/suite.Suite contains sync.RWMutex (govet)
service/common/rpc/invoke.go|12 col 2| SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
integ/workflow/persistence/routers.go|86 col 4| S1021: should merge variable declaration with assignment on next line (gosimple)
integ/workflow/persistence/routers.go|257 col 4| S1021: should merge variable declaration with assignment on next line (gosimple)
cmd/server/iwf/iwf.go|254 col 19| Error return value of dispatcher.Stop is not checked (errcheck)
cmd/server/main.go|32 col 9| Error return value of app.Run is not checked (errcheck)
service/interpreter/stateExecutionCounter.go|17 col 2| field stateIdCompletedCounts is unused (unused)
service/api/handler.go|35 col 19| func (*handler).close is unused (unused)
service/api/service.go|683 col 2| S1008: should use 'return policy.GetPersistenceLoadingType() == iwfidl.PARTIAL_WITH_EXCLUSIVE_LOCK' instead of 'if policy.GetPersistenceLoadingType() == iwfidl.PARTIAL_WITH_EXCLUSIVE_LOCK { return true }; return false' (gosimple)
service/api/handler.go|59 col 2| S1023: redundant return statement (gosimple)
service/api/handler.go|76 col 2| S1023: redundant return statement (gosimple)
service/api/handler.go|93 col 2| S1023: redundant return statement (gosimple)
integ/main_test.go|69 col 9| lostcancel: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak (govet)
service/api/cadence/client.go|252 col 8| ineffectual assignment to err (ineffassign)
integ/util.go|137 col 18| ineffectual assignment to err (ineffassign)
integ/get_with_wait_timeout_test.go|83 col 2| ineffectual assignment to err (ineffassign)
integ/wf_stop_test.go|144 col 2| ineffectual assignment to startResp (ineffassign)
service/interpreter/activityImpl.go|6 col 2| SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
integ/get_with_wait_timeout_test.go|11 col 2| SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)