IWF-405: rename and validate failure recovery policy

[longquanzheng]

Description

Checklist

• Code compiles correctly
• Tests for the changes have been added
• All tests passing
• This PR change is backwards-compatible
• This PR CONTAINS a (planned) breaking change (it is NOT backwards-compatible)

Related Issue

Closes #<issue_number>

[lwolczynski]

Closes #277

[lwolczynski]

setProceedAfterRetryExhaustedOnExecuteFailure
setProceedAfterRetryExhaustedOnWaitUntilFailure

Do we need to stick to the Failure suffix? I think RetryExhausted is enough info. I suggest:

setProceedOnExecuteAfterRetryPolicyExhausted
setProceedOnWaitUntilAfterRetryPolicyExhausted

[longquanzheng]

setProceedAfterRetryExhaustedOnExecuteFailure setProceedAfterRetryExhaustedOnWaitUntilFailure

Do we need to stick to the Failure suffix? I think RetryExhausted is enough info. I suggest:

setProceedOnExecuteAfterRetryPolicyExhausted setProceedOnWaitUntilAfterRetryPolicyExhausted

That's a great idea. Love it. Thanks!

[longquanzheng]

setProceedOnExecuteAfterRetryPolicyExhausted
setProceedOnWaitUntilAfterRetryPolicyExhausted

You meant:

setProceedAfterRetryPolicyExhaustedOnExecute
setProceedAfterRetryPolicyExhaustedOnWaitUntil

Right?

I also like what @ktrops suggested to put "onExeute" and "onWaitUnti" at the end for easier to read, and also less confusing.

"ProceedOnExecute" could make it feel like "Proceed on to execute", but its actually proceed after execute.

[lwolczynski]

setProceedOnExecuteAfterRetryPolicyExhausted
setProceedOnWaitUntilAfterRetryPolicyExhausted

You meant:

setProceedAfterRetryPolicyExhaustedOnExecute
setProceedAfterRetryPolicyExhaustedOnWaitUntil

Right?

I also like what @ktrops suggested to put "onExeute" and "onWaitUnti" at the end for easier to read, and also less confusing.

"ProceedOnExecute" could make it feel like "Proceed on to execute", but its actually proceed after execute.

Naming is difficult...

How about?:
setProceedWhenExecuteRetryPolicyExhausted
setProceedWhenWaitUntilRetryPolicyExhausted

I'll defer to @ktrops

[longquanzheng]

Yes I like that, using When make it very clear

[ktrops]

How about?
setProceedWhenRetryPolicyExhaustedOnExecute
setProceedWhenRetryPolicyExhaustedOnWaitUntil

[longquanzheng]

How about? setProceedWhenRetryPolicyExhaustedOnExecute setProceedWhenRetryPolicyExhaustedOnWaitUntil

Lol. Yeah I like this the most so far 😂
WDYT? @lwolczynski
A fun journey for this renaming discussion :P

[ktrops]

Or

setProceedToWhenRetryPolicyExhaustedOnExecute
setProceedToWhenRetryPolicyExhaustedOnWaitUntil

[lwolczynski]

How about? setProceedWhenRetryPolicyExhaustedOnExecute setProceedWhenRetryPolicyExhaustedOnWaitUntil

Lol. Yeah I like this the most so far 😂 WDYT? @lwolczynski A fun journey for this renaming discussion :P

Fine either way. I personally would try to not use the On, and stick to the previous idea, but it's okay

[ktrops]

Fine either way. I personally would try to omit the On, but it's okay

I'm ok with omitting the on

[codecov]

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.29%. Comparing base (4484a27) to head (d7bfb5e).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
.../io/iworkflow/core/mapper/StateMovementMapper.java	47.36%	7 Missing and 3 partials ⚠️
.../iworkflow/core/WorkflowStateOptionsExtension.java	42.85%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #278      +/-   ##
============================================
+ Coverage     72.54%   73.29%   +0.75%     
- Complexity      462      471       +9     
============================================
  Files            70       69       -1     
  Lines          1894     1880      -14     
  Branches        173      177       +4     
============================================
+ Hits           1374     1378       +4     
+ Misses          424      402      -22     
- Partials         96      100       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[longquanzheng]

Yeah, ExecuteRetryExhausted and WaitUntilRetryExhausted seems more clear.