Add singleNextStateUntypedInput #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longquanzheng
commented
Apr 29, 2024
| * @param stateId required. StateId of next state | ||
| * @param stateInput optional, can be null. Input for next state | ||
| * @param stateOptionsOverride optional, can be null. It is used to override the defined one in the State class | ||
| * @return state decision | ||
| */ | ||
| public static <I> StateDecision singleNextState(final String stateId, final I stateInput, final WorkflowStateOptions stateOptionsOverride) { |
There was a problem hiding this comment.
Remove because the generic type <I> here is useless
There was a problem hiding this comment.
How is it useless? It allows strongly typing on the state input?
There was a problem hiding this comment.
Oh this one is different -- the StateId is a string, not the state class. So there is no usage of restricting the input type(from the state class)
longquanzheng
commented
Apr 29, 2024
| * @param stateId required | ||
| * @param stateInput optional, can be null | ||
| * @param stateOptionsOverride optional, can be null. It is used to override the defined one in the State class | ||
| * @return state movement | ||
| */ | ||
| public static <I> StateMovement create(final String stateId, final I stateInput, final WorkflowStateOptions stateOptionsOverride) { |
There was a problem hiding this comment.
Same. Remove because the generic type <I> here is useless
There was a problem hiding this comment.
How is it useless? It allows strongly typing on the state input?
There was a problem hiding this comment.
same as above. the stateId is a string(as raw usage), not a state class
lanespade
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.