Issue 51: Adding updatedAt and labels to the output #53
Conversation
|
Thanks for the review. Just pushed some changes |
src/gitHubIssueFetcher.ts
Outdated
| } | ||
|
|
||
| interface GitHubRepository { | ||
| nameWithOwner: string; | ||
| } | ||
|
|
||
| export interface GitHubLabelEdge { | ||
| node: { | ||
| name: string |
There was a problem hiding this comment.
I just ran npm run lint and it pointed out some missing semi-colons and extra whitespace. We should probably mention that in our README.
There was a problem hiding this comment.
I'll run and add to the readme.
Happy to open another ticket to make it so that linting runs in pre-push hooks. I was actually thinking about linting earlier and then forgot when I went to commit
There was a problem hiding this comment.
For other projects, I have used a pre-commit hook for linting. I like catching that as early in the process as possible. We used husky. If you could create a ticket, that would be much appreciated. Thanks!
|
Ran linting. Added info to it to the README. Let me know if there's anything else outstanding! |
Updated the graphQL query to grab createdAt and all labels (I defaulted to 100, but didn't do another page grab). Not sure if y'all want to limit the number of labels fetched or not, but I would be worried if a ticket had more than 100.
Updated the output to include and array of strings for the labels (with just the label name) and the createdAt field