Repository navigation
fix(desktop): fit browser previews at any window zoom - #833
Merged
Merged
Conversation
Upstream divergenceBoth sides are compared with upstream at the in-order tip
Upstream files whose difference changes (2)
|
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Fixes cropping and wrong click locations in fitted desktop browser previews across independent window and page zoom.
Fitted browser previews crop the page when the desktop window or preview page is zoomed out and leave unused space when zoomed in. The page can also measure a different CSS viewport from the requested size. Screenshots capture the same incorrect surface, and agent clicks miss their targets because their logical coordinates are sent directly to the scaled surface.
Convert requested CSS dimensions to CDP device-independent dimensions using page zoom, and account for host window zoom in presentation scaling. Map agent click coordinates into the fitted surface while preserving logical cursor coordinates. Clicks use the scale successfully applied to their CDP session while a resize or window-zoom update waits. Restore every tab's independent page zoom before refreshing fitted presentations concurrently, so a busy tab cannot delay restoration for the others. Refreshes read the latest requested viewport without rewriting it and check session ownership, preserving queued resizes and preventing a detached session from changing its replacement.
Validation
resolveBrowserViewportLayoutto derive presentation. All nine combinations of window zoom 80%/100%/120% and page zoom 90%/100%/110% preserve the requested 1280×800 CSS viewport, fill the captured surface to all four edges, and deliver locator clicks to the button. Window-zoom changes in this matrix exercisereapplyZoomwithout a renderer presentation resend.Manager.test.ts,DesktopWindow.test.ts, andhostedBrowserWebviewStyle.test.ts. Desktop typecheck, targeted lint, and formatting checks pass.Known limitation: presets rendered at fit scale 1 still inherit window zoom in their measured CSS size. This pre-existing natural-size path is tracked for upstream intake; its guest-zoom composition needs adaptation to the fork's CDP presentation path.
Before / after
The same synthetic 1280×800 page in a fitted surface at 80% window zoom, captured through the real manager on main and this branch:
The page-zoom correction at 80% window zoom and 90% page zoom, using renderer-derived presentation. Before, the requested 1280×800 viewport measures 1422×888 and crops the bottom-right edge; after, it measures 1280×800 and fills the surface:
Written by an agent (Codex, gpt-6.1-sol).