Skip to content

fix(web): say that auto-merge also merges commits pushed after it is on - #596

Merged
incognitojam merged 1 commit into
mainfrom
fix/pr-auto-merge-later-pushes
Oct 1, 2026
Merged

incognitojam merged 1 commit into
mainfrom
fix/pr-auto-merge-later-pushes

Conversation

@incognitojam

Copy link
Copy Markdown
Owner

The auto-merge confirmation said when the merge would happen but not what it would include. On GitHub, auto-merge stays on when someone with write access pushes to the branch, and the newer head is merged once it is ready. A reader could reasonably assume the merge covers only what they reviewed when they confirmed.

Change

  • The confirmation now ends with "Commits pushed after this are merged too, unless the host turns auto-merge off." The wording does not depend on the host. GitHub turns auto-merge off for some pushes, such as one from someone without write access, and other hosts have their own rules.
  • The Review and merge section of docs/user/source-control.md says the same.
Before After
Auto-merge confirmation before Auto-merge confirmation after

Validation

  • Opened the auto-merge confirmation on a pull request in a dev server and read the new sentence in the dialog. The scratch repository does not allow auto-merge, so the browser script added enable-auto-merge to that pull request's viewer permissions in the response before it reached the page. That made the menu entry appear. The dialog was cancelled, and the pull request has no auto-merge request.
  • Web typecheck passes.

Written by an agent (Claude Code, claude-opus-5-5).

The auto-merge confirmation said when the merge would happen but not what it would include. GitHub keeps auto-merge on when someone with write access pushes, and merges the newer head, so the dialog and the source control guide now say that later commits are merged too unless the host turns auto-merge off.
@incognitojam
incognitojam merged commit ab60ea3 into main Oct 1, 2026
17 checks passed
@incognitojam
incognitojam deleted the fix/pr-auto-merge-later-pushes branch October 1, 2026 18:33
incognitojam pushed a commit that referenced this pull request Oct 16, 2026
…#15851)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

Fork adaptation: Quick merges now resolve the merge method inside the shared client runtime's action lane. The fork's head guard moves with it: the runtime sends the head commit from its fresh detail read as `expectedHeadSha`, so GitHub refuses the merge if new commits arrived since. The fork-only quick-action test is replaced by a runtime test for that, and the ledger paths follow. The user guide keeps the fork's sentence that auto-merge also merges commits pushed after it is on (fork #596) beside upstream's new quick-action paragraph.

(cherry picked from commit 7ffa218)
Upstream-PR: 15851
Fork-Feature: pull-request-merge-head-guard
incognitojam pushed a commit that referenced this pull request Oct 16, 2026
…#15851)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

Fork adaptation: Quick merges now resolve the merge method inside the shared client runtime's action lane. The fork's head guard moves with it: the runtime sends the head commit from its fresh detail read as `expectedHeadSha`, so GitHub refuses the merge if new commits arrived since. The fork-only quick-action test is replaced by a runtime test for that, and the ledger paths follow. The user guide keeps the fork's sentence that auto-merge also merges commits pushed after it is on (fork #596) beside upstream's new quick-action paragraph.

(cherry picked from commit 7ffa218)
Upstream-PR: 15851
Fork-Feature: pull-request-merge-head-guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant