Repository navigation
fix(web): list the branch pull request in the thread hover card - #587
Merged
Merged
Conversation
The sidebar hover card only listed pull requests linked to the thread, so a thread whose badge came from the pull request found through its branch showed no pull request in the card.
incognitojam
pushed a commit
that referenced
this pull request
Oct 3, 2026
…otgg#11144) (cherry picked from commit e8ca3a8) Fork adaptation: Keep the fork's linked pull request badge from fork #537 and #587 on upstream's new presentation resolver: a thread with additional unrelated links shows the current number followed by +N (42+2 rather than upstream's +3), the sidebar badge stays a plain link that relies on the thread hover card, and the hover card keeps its row component, now with upstream's pull request glyph. Upstream's removal of the unused settled-row hover colours and the per-state colour table is taken, as both came from earlier upstream imports. The fork-only View pull request command, linked-thread count, and draft merge policy on the Checks tab adopt upstream's pull request, link, and draft glyphs, as upstream's new lint rule requires. Upstream-PR: 11144 Fork-Feature: pull-request-linked-extras
incognitojam
pushed a commit
that referenced
this pull request
Oct 10, 2026
…tgg#13211) (cherry picked from commit 0fcd5f9) Fork adaptation: this takes in upstream's badge in full and retires the fork's badge differences from fork #537, as decided in fork #658. Web and mobile show upstream's `+N` linked count instead of the fork's current number followed by the additional count, the sidebar badge keeps upstream's tooltip, and the fork's bare no-tooltip sidebar link and its badge tests are removed, restoring upstream's badge logic test and mobile expectations. The sidebar thread hover card keeps listing the pull request found through the thread's branch (fork #587), now the only invariant of the `pull-request-linked-extras` ledger entry, with tests for that list. Upstream-PR: 13211 Fork-Feature: pull-request-linked-extras
incognitojam
pushed a commit
that referenced
this pull request
Oct 10, 2026
…tgg#13211) (cherry picked from commit 0fcd5f9) Fork adaptation: this takes in upstream's badge in full and retires the fork's badge differences from fork #537, as decided in fork #658. Web and mobile show upstream's `+N` linked count instead of the fork's current number followed by the additional count, the sidebar badge keeps upstream's tooltip, and the fork's bare no-tooltip sidebar link and its badge tests are removed, restoring upstream's badge logic test and mobile expectations. The sidebar thread hover card keeps listing the pull request found through the thread's branch (fork #587), now the only invariant of the `pull-request-linked-extras` ledger entry, with tests for that list. Upstream-PR: 13211 Fork-Feature: pull-request-linked-extras
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar thread hover card listed only the pull requests linked to the thread. A thread whose badge comes from the pull request found through its branch (for example one an agent opened with
gh pr createwithout linking it) showed a pull request number on the row and none in the card. Since #537 removed the badge's own tooltip, the card is the only place to read that pull request's title.The card now gets the same pull request the row's badge shows and lists it when the thread has no linked pull requests. Linked pull requests are listed as before. The card also no longer draws an empty divider when every link is a dismissed stack member. The branch pull request reuses the linked list's row markup, now a small
PullRequestMiniListRowcomponent.The
pull-request-linked-extrasledger entry gains the new invariant.Validation
Ran the web client against a copy of real data and hovered sidebar rows in headless Chromium:
The sidebar search-result rows have no pull request badge, so their card still lists linked pull requests only.
Written by an agent (Claude Code, claude-opus-5-5).