Repository navigation
chore(upstream): track the preview focus isolation change - #553
Merged
Merged
Conversation
An agent click in a preview tab takes keyboard focus from the composer, even from a hidden tab in another thread. An open upstream change hosts preview pages outside the app window's focus hierarchy so an agent click cannot move focus at all. This adds it to `.github/upstream-tracked-prs.json`. It reworks page display, input and capture and has no maintainer review yet, so the fork watches it rather than importing it early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent
preview_clicktakes keyboard focus from the composer, even when it clicks a hidden tab in another thread, so what the user types next goes into the previewed page. pingdotgg#11577 is an open upstream change that hosts preview pages outside the app window's focus hierarchy, so an agent click cannot move focus at all.This PR adds pingdotgg#11577 to
.github/upstream-tracked-prs.json. The fork watches it rather than importing it early: it changes 19 files across page display, input handoff, capture and tab lifecycle, which overlaps the fork's hidden-tab capture, recording and mini player, and it has no maintainer review and conflicts with upstreammain.The smaller upstream fix, pingdotgg#13914, restores focus after the click. In a desktop dev build it kept 56 to 60 of 60 typed keys in the composer across three agent clicks, against 16 to 21 without it, so a few keystrokes can still reach the page.
Validation
node scripts/upstream/tracked-prs-report.tslists it as open with the reason shown.vp test run upstreaminscriptspasses (42 tests), includinglib/tracked-prs.test.ts.Written by an agent (Claude Code, claude-fable-5-1).