Repository navigation
chore(upstream): track the settings Back fix - #549
Merged
Merged
Conversation
Back and Escape in Settings call history.back(), so after moving between settings pages, or switching environments on the Providers page, they step back through those pages instead of closing Settings. Upstream fixed this in pingdotgg#13516, which returns to the last main app URL instead. This adds it to `.github/upstream-tracked-prs.json`. It conflicts with 13 earlier pending sidebar and settings PRs at the fork's baseline, so it waits for regular intake rather than an early import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back and Escape in Settings call
history.back(), so after moving between settings pages, or switching environments on the Providers page, they step back through those pages instead of closing Settings. Upstream fixed this in pingdotgg#13516 (merged 2026-09-24), which returns to the last main app URL instead.This PR adds pingdotgg#13516 to
.github/upstream-tracked-prs.json. It is not yet onmainor any intake branch.node scripts/upstream-queue.ts early 13516 --through upstream/mainreports that it does not apply at the reconciled boundary:AppSidebarLayout.tsx,SidebarChrome.tsxandsettings.tsxconflict with 13 earlier pending upstream PRs, such as pingdotgg#13212 and pingdotgg#13139. It therefore waits for regular intake rather than an early import.Validation
node scripts/upstream-tracked-prs-report.tslists it as pending (beyond target), 12.9 days ahead of the fork tip.scripts/upstream-tracked-prs.test.tspasses.Written by an agent (Claude Code, claude-opus-5-5).