Skip to content

fix(windows): normalize shell and Explorer paths - #308

Merged
incognitojam merged 3 commits into
mainfrom
styal/port-windows-path-fixes
Sep 4, 2026
Merged

fix(windows): normalize shell and Explorer paths#308
incognitojam merged 3 commits into
mainfrom
styal/port-windows-path-fixes

Conversation

@incognitojam

@incognitojam incognitojam commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Note

TL;DR: Fix Windows PATH repair and File Explorer reveal behavior.

Windows-launched environments can inherit quoted PATH fragments or have their shell PATH reordered behind guessed CLI directories. File links can also reach the server with forward slashes, which Explorer misinterprets inside its select switch.

Windows PATH entries are now sanitized while preserving shell priority. Explorer receives native separators without changing the target recorded by styal, and POSIX path behavior is unchanged.

Source PRs:

  • pingdotgg/t3code#8746
  • pingdotgg/t3code#8748
  • pingdotgg/t3code#9551

Verification:

  • vp test run apps/server/src/process/externalLauncher.test.ts apps/desktop/src/shell/DesktopShellEnvironment.test.ts packages/shared/src/shell.test.ts — 65 passed, 1 Windows-only smoke test skipped
  • Targeted lint passed for all six changed files
  • Targeted formatting passed for all six changed files
  • Server, desktop, and shared package typechecks passed
  • Fork feature ledger overlap review found no tracked overlaps

Written by an agent (styal, gpt-5.6-sol via the Codex harness).

@github-actions github-actions Bot added the size:M label Sep 4, 2026
@incognitojam
incognitojam force-pushed the styal/port-windows-path-fixes branch from b9a4152 to 61b92dd Compare September 4, 2026 12:23
@incognitojam
incognitojam merged commit 7d23b34 into main Sep 4, 2026
11 checks passed
@incognitojam
incognitojam deleted the styal/port-windows-path-fixes branch September 4, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants