Repository navigation
test(mobile): cover the message image grid layout - #1196
Merged
Merged
Conversation
Move the grid's tile selection and the split between grid images and listed files into a pure helper, test it, and record the feature in the fork feature ledger. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Upstream divergenceBoth sides are compared with upstream at the in-order tip
Upstream files whose difference changes (1)
|
incognitojam
marked this pull request as ready for review
November 1, 2026 20:03
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mobile message image grid from #1175 had no tests, so it had no fork feature ledger entry, and upstream intake batch 49 (pingdotgg#23135) had to re-apply it by hand when it rebuilt ThreadFeed's message body.
This moves the grid's decisions out of
ThreadFeed.tsxinto a pure helper,messageImageGrid.ts, and tests them:ThreadFeedrenders the same views from the helper's result, so the grid behaves as before. The newmobile-message-image-gridledger entry records the invariants, paths, and tests. It is markedreview-neededwith upstream statuspartial: upstream pingdotgg#27373, which the fork has not taken yet, moves user message images into a collage that shows every image with no tile limit or overflow count, while assistant images still stack. Intake of that PR needs to decide which layout the fork keeps.Validation: compared the batch 49 version of
ThreadFeed.tsxwith the #1175 diff: the grid component, tile size, pending/sent/assistant call sites, and the grid/file-list split are all unchanged apart from the new body wrapper, whosepx-3.5padding matches the tile width calculation. The new tests cover each case in the list above.Also checked on an Android emulator (Pixel 7, Android 17) against a dev server with synthetic fixture threads:
screen-4.png, and swiping goes on toscreen-5.png, one of the hidden images.I didn't capture a message with a single referenced image on the emulator; the tests cover that it keeps the single layout.
Written by an agent (Claude Code, claude-opus-5-5).