Skip to content

Develop #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markteekman merged 4 commits into from
Aug 13, 2021
Merged

Develop #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a95c55b
Remove roles from landmarks (redundant)
markteekman Aug 13, 2021
bff4959
Replace <strong> with <h3> tag
markteekman Aug 13, 2021
8a97bf0
Remove main menu skip link
markteekman Aug 13, 2021
c63cb3c
Update version to 1.0.1
markteekman Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "accessible-astro-starter",
"version": "1.0.0",
"version": "1.0.1",
"private": true,
"scripts": {
"start": "astro dev",
Expand Down
2 changes: 1 addition & 1 deletion src/components/Footer.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<footer role="contentinfo">
<footer>
<section class="space-16 color-neutral">
<div class="container">
<p>&copy; Footer Copyright</p>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Header.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import Navigation from '../components/Navigation.astro'
import SkipLinks from '../components/SkipLinks.astro'
---
<header role="banner">
<header>
<SkipLinks client:load />
<section class="space-16 color-neutral">
<div class="container">
Expand Down
13 changes: 8 additions & 5 deletions src/components/SkipLinks.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<div class="container">
<nav class="skip-links" role="navigation" aria-label="Skiplinks">
<ul>
<li><a href="#main-navigation" data-skip-link>Skip to main menu</a></li>

<!-- NOTE: add this when you have content or hyperlinks to skip before you main menu!
<li><a href="#main-navigation" data-skip-link>Skip to main menu</a></li> -->
<li><a href="#main-content" data-skip-link>Skip to main content</a></li>
</ul>
</nav>
Expand All @@ -26,11 +28,12 @@
event.preventDefault()
const target = event.target.getAttribute('href')

// NOTE: add this when you have content or hyperlinks to skip before you main menu!
// set focus to first menu item for skip link to main navigation
if (target === '#main-navigation') {
const navigation = document.querySelector('#main-navigation')
navigation.querySelector('a').focus()
}
// if (target === '#main-navigation') {
// const navigation = document.querySelector('#main-navigation')
// navigation.querySelector('a').focus()
// }

// set focus to first h1 for skip link to main content
if (target === '#main-content') {
Expand Down
2 changes: 1 addition & 1 deletion src/layouts/DefaultLayout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ let subtitle = 'Accessible Astro Starter'
<Header />

<!-- main -->
<main id="main-content" role="main">
<main id="main-content">

<slot />

Expand Down
15 changes: 12 additions & 3 deletions src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,18 @@ import DarkMode from '../components/DarkMode.astro'
<h2 class="space-16 bottom">Grid example</h2>
</div>
<div class="container" data-auto-grid="3">
<p><strong>Column 1 | Cell 1</strong> - Lorem ipsum dolor sit amet consectetur adipisicing elit. Exercitationem accusantium placeat eius officiis veniam totam. Earum eos et voluptate dolorem. <strong><a href="#">Tab to me!</a></strong></p>
<p><strong>Column 2 | Cell 2</strong> - Lorem ipsum dolor sit amet consectetur adipisicing elit. Exercitationem accusantium placeat eius officiis veniam totam. Earum eos et voluptate dolorem.</p>
<p><strong>Column 3 | Cell 3</strong> - Lorem ipsum dolor sit amet consectetur adipisicing elit. Exercitationem accusantium placeat eius officiis veniam totam. Earum eos et voluptate dolorem.</p>
<div class="box">
<h3>Column 1</h3>
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Exercitationem accusantium placeat eius officiis veniam totam. Earum eos et voluptate dolorem. <strong><a href="#">Tab to me!</a></strong></p>
</div>
<div class="box">
<h3>Column 2</h3>
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Exercitationem accusantium placeat eius officiis veniam totam. Earum eos et voluptate dolorem.</p>
</div>
<div class="box">
<h3>Column 3</h3>
<p>Lorem ipsum dolor sit amet consectetur adipisicing elit. Exercitationem accusantium placeat eius officiis veniam totam. Earum eos et voluptate dolorem.</p>
</div>
</div>
</section>
<section class="space-32">
Expand Down