Skip to content

Path fixes for CLI tool#186

Merged
markteekman merged 2 commits into
mainfrom
bug/cli-paths
May 2, 2026
Merged

Path fixes for CLI tool#186
markteekman merged 2 commits into
mainfrom
bug/cli-paths

Conversation

@markteekman
Copy link
Copy Markdown
Member

@markteekman markteekman commented May 2, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Fixed navigation menu activation to correctly handle URLs with trailing slashes.
  • Chores

    • Bumped version to 5.2.1.
    • Improved SCSS asset path configuration in the generated starter template.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 2, 2026

Deploy Preview for accessible-astro-starter-incluud ready!

Name Link
🔨 Latest commit 6bae289
🔍 Latest deploy log https://app.netlify.com/projects/accessible-astro-starter-incluud/deploys/69f5e86d12e81500083af082
😎 Deploy Preview https://deploy-preview-186--accessible-astro-starter-incluud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b6e794e-6da6-464b-9010-b97292aaa003

📥 Commits

Reviewing files that changed from the base of the PR and between 0f5d949 and 6bae289.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • package.json
  • packages/create-accessible-astro-starter/package.json
  • packages/create-accessible-astro-starter/src/templates.ts

📝 Walkthrough

Walkthrough

The PR bumps the package version from 5.2.0 to 5.2.1 and updates generated templates to add SCSS asset path resolution and improve navigation pathname normalization logic.

Changes

Version and Template Improvements

Layer / File(s) Summary
Template Improvements
packages/create-accessible-astro-starter/src/templates.ts
The Astro config template now adds loadPaths: [fileURLToPath(new URL('./src/assets', import.meta.url))] to SCSS preprocessor options. Navigation template pathname normalization updated with revised regex literal for consistent trailing slash removal in both currentPath and itemPath.
Version Metadata
package.json, packages/create-accessible-astro-starter/package.json
Package version bumped from 5.2.0 to 5.2.1 in both manifest files.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

  • Feature/update astro 6 #181 — Modifies the same SCSS preprocessor configuration to add Vite loadPaths entry for ./src/assets resolution.

Poem

🐰 A nibble here, a path there,
Templates improved with extra care!
SCSS finds assets with newfound grace,
Navigation trails trim their trailing space.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Path fixes for CLI tool' accurately describes the main change: fixing path-related issues in the CLI tool, as evidenced by the template path normalization updates and SCSS loadPaths configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug/cli-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@markteekman markteekman requested a review from peterpadberg May 2, 2026 12:05
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 2, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • package-lock.json
  • package.json
  • packages/create-accessible-astro-starter/package.json
  • packages/create-accessible-astro-starter/src/templates.ts

Reviewed by gpt-5.2-codex-20260114 · 193,493 tokens

@markteekman markteekman merged commit 19ab903 into main May 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants